Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods handling Fixed64 values on CodedOutputStream should take UInt64 parameters #5

Closed
csgero opened this issue Oct 7, 2014 · 3 comments
Closed

Methods handling Fixed64 values on CodedOutputStream should take UInt64 parameters #5

csgero opened this issue Oct 7, 2014 · 3 comments
Assignees
@alexeyxo
Labels
bug
Milestone
release 1.0

Comments

@csgero
Copy link

csgero commented Oct 7, 2014

In the generated code fields holding Fixed64 values are (correctly) generated with type UInt64, but the methods writeFixed64 and computeFixed64Size on CodedOutputStream take the value parameter as Int64. Because of this the generated code does not compile.
@alexeyxo alexeyxo added the bug label Oct 7, 2014
@alexeyxo alexeyxo added this to the release 1.0 milestone Oct 7, 2014
@alexeyxo
Copy link
Owner

alexeyxo commented Oct 7, 2014

Hi!
I fixed this bug already, but I'll make a push in 2-3 hours.
Thanks.

@alexeyxo alexeyxo self-assigned this Oct 7, 2014
alexeyxo added a commit that referenced this issue Oct 7, 2014
@alexeyxo
fix: Fixed32/64 and SFixed32/64 primitives #5
b21093c
@alexeyxo
Copy link
Owner

alexeyxo commented Oct 7, 2014

You can check. If all ok you can close issue.

@csgero
Copy link
Author

csgero commented Oct 8, 2014

Looks good. Thanks for the quick response.

@csgero csgero closed this as completed Oct 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeyxo alexeyxo

Labels
bug
Projects
None yet
Milestone
release 1.0
Development

No branches or pull requests
2 participants
@csgero @alexeyxo