Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go scalar to the latest version #69

Merged
merged 4 commits into from
Nov 20, 2018
Merged

Update go scalar to the latest version #69

merged 4 commits into from
Nov 20, 2018

Conversation

pborzenkov
Copy link
Contributor

This PR updates go-scalar to the latest version bringing support for custom parsing for values in arguments structs and not only pointers.

Allows to use values (not pointer) with custom TextUnmarshaler.

Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Values are much more convenient to use in argument structs, so update
README to use them instead of pointers in the example as we now support
this.

Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.886% when pulling a6af419 on pborzenkov:update-go-scalar into f7c0423 on alexflint:master.

@alexflint
Copy link
Owner

Thanks again @pborzenkov

@alexflint alexflint merged commit fb7d95b into alexflint:master Nov 20, 2018
@pborzenkov pborzenkov deleted the update-go-scalar branch November 20, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants