This repository has been archived by the owner on Mar 2, 2019. It is now read-only.
Join operators. #15
Merged
Join operators. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds LEFT OUTER JOIN, CROSS JOIN and the optional NATURAL operator.
|
It looks good to me except the coverage decreased. Let's see what @alexfu will say. |
| } | ||
|
|
||
| public SelectJoinBuilder naturalLeftOuterJoin(String table) { | ||
| return new SelectJoinBuilder(this, table, JoinType.NATURAL_LEFT_OUTER_JOIN); |
There was a problem hiding this comment.
naturalLeftOuterJoin, naturalJoin, crossJoin, and leftOuterJoin in this file can be removed. They are no longer being used anywhere. This will probably bring the code coverage back up as well.
|
Been so busy, haven't been able to get to any of my own projects in a while... @monxalo thanks for this contribution! |
|
@alexfu No problem. I started using this library and helped me so i'm happy to help improve it. |
|
@monxalo, do you need more people on your project? I am happy to contribute. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds LEFT OUTER JOIN, CROSS JOIN and the optional NATURAL operator.