-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser support policy #37
Comments
@substack from IRC:
I'm pretty new to the |
If it can be supported with simple shims (via es5-shim or similar) then making the code free of browser nonsense is a win. The users that don't care about older browsers (more and more every day) will benefit from a smaller and more maintainable module and the module devs wont be burdened with debugging stupid browsers if they don't care about them. It is not hard to just add a note to the readme about "legacy" browsers. Really this comes down to the decision of the module authors. If you don't care about supporting old browsers (and you absolutely don't have to care) then just tell people to use a shim. There isn't a right or wrong here. |
We don't really need a universal support policy. In this particular case the downsides to old browser support (a much bigger bundle size) outweigh the benefits for this particular module. Other times it's rather easy to inline a little Array.isArray() function and everything works. |
Just to clarity, when I say I don't care its because I don't support IE8 in my own personal projects. However I'm still the one there gets the angry emails when things don't work and that I care about. |
Tell them to use a shim. If they are writing an angry email to a volunteer
|
What does this change mean to Testling? Testling browserifies test bundles and runs them in older browsers, such as IE6, 7, and 8. |
@pkrumins This will only affect modules that use the |
We really need to get rid of this global use of browser and process. I
|
@substack great! |
I'm okay with supporting three latest versions of IE 9, 10 & 11. I would speculate that node stack is mostly used by startups and personal projects who don't often support IE8 and lesser. Those who need to support would be able to polyfill and get it work with a bit of extra effort. I would love to have a paragraph in the readme talking about this. Thoughts? |
Its actually a huge maintenance burden! @substack would it be possible to drop IE8 & 9 support entirely?
It will need to be IE10 & 11, since typed arrays isn't supported by IE9.
I'm thinking:
|
I've made a branch without legacy browser support so you can tell us how huge the impact is. |
Sounds great! Im in favor or dropping old IE support. |
@alexgorbatchev please publish version 3.0.0 By the way a single shims is needed in order to support IE11 :( |
Do we have automated CI browser testing setup for this repo to avoid breakage? |
No and you are welcome to tell us how :) PS: @alexgorbatchev is the one with admin rights. |
3.0.0 has been published |
I added travis, however it fails because of firefox... https://travis-ci.org/alexgorbatchev/node-browser-builtins/builds/14818705#L444
|
What is being used to launch Firefox? Is that something that Travis or testling provides? |
As a principal I believe that either you support a old browser or you don't, there should be no half solutions. It is way to complicated for those there use this project to care about browser support on a individual module or function level.
So since the big 2.0.0 bump we fully support IE8+. I made this decision because there was already some IE8 support and I didn't want more migration trouble for userland than they already where (caused by the node version bump).
Some time has now passed and pull-request #36 and issue #19 are good reasons to drop IE8 support. Since I'm quite distant from the browserify community I can't really make this decision.
/cc @alexgorbatchev @substack @Raynos @defunctzombie
The text was updated successfully, but these errors were encountered: