Add tests for conditional scrabble proxy

gflownet/proxy/scrabble.py

@@ -104,7 +104,7 @@ def __call__(
             output[valid_states] = -1.0 * self.scores[states[valid_states]].sum(dim=1)
             return output
         elif isinstance(states, list):
-            if not self.conditional:
+            if self.conditional:
                 raise ValueError(
                     "The Scrabble proxy doesn't support input states in a non-tensor "
                     "format when in conditional mode."

tests/gflownet/proxy/test_scrabble_proxy.py

@@ -15,6 +15,11 @@ def env():
     return Scrabble(max_length=7, device="cpu")
 
 
+@pytest.fixture
+def env_conditional():
+    return Scrabble(max_length=7, device="cpu", conditional=True)
+
+
 @pytest.mark.parametrize(
     "samples, scores_expected",
     [
@@ -95,3 +100,44 @@ def test__scrabble_scorer__returns_expected_scores_input_state2proxy(
     sample_proxy = env.state2proxy()
     score = proxy(sample_proxy)
     assert score.tolist() == [-1.0 * score_expected]
+
+
+@pytest.mark.parametrize(
+    "condition, sample, score_expected",
+    [
+        (
+            "ABCDTTT",
+            "C A T",
+            3 + 1 + 1,
+        ),
+        (
+            "AACDOZZ",
+            "D O G Z",
+            0,  # Word not in condition and not in vocabulary
+        ),
+        (
+            "ABCDEFG",
+            "B I R D",
+            0,  # Word in vocabulary but not in condition
+        ),
+        (
+            "FGGNNN",
+            "G F N",
+            0,  # Word in condition but not in vocabulary
+        ),
+        (
+            "DEFINRS",
+            "F R I E N D S",
+            4 + 1 + 1 + 1 + 1 + 2 + 1,
+        ),
+    ],
+)
+def test__scrabble_scorer__returns_expected_scores_conditional_input_state2proxy(
+    env_conditional, proxy, condition, sample, score_expected
+):
+    proxy.setup(env_conditional)
+    env_conditional.reset(condition=condition)
+    env_conditional.set_state(env_conditional.readable2state(sample))
+    sample_proxy = env_conditional.state2proxy()
+    score = proxy(sample_proxy)
+    assert score.tolist() == [-1.0 * score_expected]