Setup continuous integration #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carriepl
force-pushed
the
black_ci
branch
2 times, most recently
from
ca8cedb
to
8ca5ce2
Compare
carriepl
changed the title
alexhernandezgarcia
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts in place some continuous integration for the repo. The way it is setup, every time there is a push to a branch containing this code, it triggers 3 things :
1- Validating the code formatting using Black (here, Black is not configured to change the files, only check them)
2- Validating the import formatting using isort (here, isort is not configured to change the files, only check them)
3- Running the unit tests using pytest
As soon as one step fails, the process stops. Assuming no error, the whole process currently takes about 7-8minutes.
The result of this check is displayed near the PR merge button but, as currently configured, it doesn't prevent a PR from being merged.