[Small PR] Logging dir and buffer outputs: fix issue and improvements #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gflownet/utils/buffer.py
Outdated
| data_path=None, | ||
| train=None, | ||
| test=None, | ||
| logger=None, | ||
| **kwargs, | ||
| ): | ||
| self.logger = logger | ||
| self.datadir = logger.datadir |
There was a problem hiding this comment.
logger defaults to None, if this is allowed it should be handled here; otherwise make it required?
There was a problem hiding this comment.
Good point, done here: f8c235c
Comment on lines
+74
to
+77
| if "path" in logdir: | ||
| self.logdir = Path(logdir.path) | ||
| else: | ||
| self.logdir = Path(logdir.root) |
There was a problem hiding this comment.
Why is this needed? It seems very arbitrary.
There was a problem hiding this comment.
Not sure if it's strictly needed but it's additional flexibility. Currently, logdir.path is created in main.py, but this will make it still work if the code is run from a different script that does not do that.
michalkoziarski
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note for reviewers: There are many files changed but it's mostly the same change applied to many config files.
This PR fixes an issue introduced in a recent PR and makes various changes to hopefully improve the handling of the logging directory and the buffer output files:
main.pyto make the actual logging directory be Hydra's output directory. Let's call this directory/log/dir/, which will be stored inconfig.logger.logdir.path/log/dir/data/(as well as a /log/dir/ckpts/`) meant to store the replay buffer, the train data and the test data.env.buffer.train.output_csvandenv.buffer.train.output_pkl(and the test counterparts) in order to make use of the buffer. This simplifies its use and the code. And the replay, train and test output files will always be stored simply as/log/dir/data/replay.pkl,/log/dir/data/train.csv,/log/dir/data/train.pkl, etc.