Test HautelookAliceBundle with Faker Provider #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexislefebvre
force-pushed
the
test-faker-provider
branch
from
bb2cd75
to
f943250
Compare
alexislefebvre
force-pushed
the
test-faker-provider
branch
from
f943250
to
ba94ce1
Compare
|
The error is:
It occurs with Symfony 2.8 and hautelook/alice-bundle v1.2.0. |
It still fails
|
@alexislefebvre Sorry for the late response. Just had a look. The current test is setting up the container service manually. So the container definition set by symfony with your configuration is overwritten. If you want to have your changes take affect delete the mocked service definition (line 351-355): |
There is an error if some fixtures are loaded in the same test: SQLSTATE[HY000]: General error: 17 database schema has changed
HautelookAliceBundle: use version ~1.2 only PHPUnit: use ~5.1 instead of 5.1.*, it will install 5.2, the current version
alexislefebvre
force-pushed
the
test-faker-provider
branch
from
3f7e817
to
bdb83df
Compare
Don't perform queries through the repository to check the data, it caused this error: SQLSTATE[HY000]: General error: 17 database schema has changed Restore "hautelook/alice-bundle" = "~0.2|~1.2" (avoid errors with Symfony 2.3)
|
@estahn thanks a lot, I should have paid attention to the beginning of the test, I didn't see it was defining another provider, sorry. It should work now, I'll clean it and submit a PR to the upstream. |
|
It has been moved to upstream: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.