Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script errors on load? #29

Closed
dazinator opened this issue Nov 27, 2018 · 3 comments
Closed

script errors on load? #29

dazinator opened this issue Nov 27, 2018 · 3 comments

Comments

@dazinator
Copy link
Contributor

Having put these two scripts on a page:

 <script src="~/lib/systemjs/system.js"></script>
 <script src="~/lib/systemjs-hmr/dist/systemjs-hmr.js"></script>

The systemjs-hmr.js script errors on load with:

image

image

This is using systemjs-hmr@2.0.9 and systemjs@2.1.1

Am I doing something stupid?

@alexisvincent
Copy link
Owner

So the issue is that this library hasn't been updated to function with SystemJS >2.0.0. Largely because I'm primarily writing clojure(script) now and haven't had time to focus on this library.

So you're not doing anything stupid.

I strongly expect with some structural work this could be updated to work, especially since v2 seems to have more exposed that would make HMR even easier. However, I don't currently have time to do the work myself.

If you would be up for having a look, I can provide some support.

@dazinator
Copy link
Contributor Author

Ok, I am just trying to get to grips with the basics at present, in fact I am getting a very basic sample up and running. Not using any transpilation, just loading an AMD module into the browser, and then in the console I am calling System.reload('moduleId');

I have been testing with system 0.21 and I'll send a PR to make that work, as currently it doesn't (system 0.19 and 0.20 do work). I am testing with 0.21.5 because that is is the latest system release prior to the jump to 2.0 and it so it seems like it's a lot less effort to get this working first whilst I learn my way around :-)

@dazinator
Copy link
Contributor Author

Im going to close this, Ill open a new issue to track support for systemjs 2.0 but I won't be working on that I suspect for a while, as I am happy for the time being on 0.21 ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants