Adding option to disable logging to the console #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joeldenning Thanks for this! Note, that upgrading to systemjs-hmr@next is going to be a breaking change anyway :) Since the whole state hydration mechanism is different. |
|
Wait, I didn't see this console.logging code, but why not use a package like debug? That's way more flexible and used by a lot of other libraries. Although, more in Node.js than on the client side. |
|
@peteruithoven Sure, all the same to me really, since this is the old version. Want to send a PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See alexisvincent/systemjs-hmr#14, which is code that is waiting to be published in systemjs-hmr. Until that is published, this pull request should not be merged.
This simply exposes a new function
setDebugLoggingthat allows the user to turn of logging things to the console. Note that when this project migrates to thenext.jsof systemjs-hmr, that this function will no longer be exported from systemjs-hmr. So potentially it would cause a breaking change for those who are using the function but then upgrade to systemjs-hmr@next.