Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle non provided entries #136

Merged
merged 1 commit into from
Mar 2, 2017
Merged

Conversation

mpfau
Copy link
Contributor

@mpfau mpfau commented Mar 2, 2017

Current implementation fails, if no entries are provided.

This fix has been tested against systemjs-hmr@2.0.8.

@alexisvincent
Copy link
Owner

:) Shot

@alexisvincent alexisvincent reopened this Mar 2, 2017
@alexisvincent alexisvincent merged commit 8d5d669 into alexisvincent:master Mar 2, 2017
@mpfau
Copy link
Contributor Author

mpfau commented Mar 2, 2017

Just noticed, that entries=[] would be better. entries={} works but is slightly confusing...

Do you want to change that or should I submit another pull request?

@alexisvincent
Copy link
Owner

Oh yeah, either. I'm happy to change, but if you submit a PR I'll merge.

mpfau pushed a commit to mpfau/systemjs-hot-reloader that referenced this pull request Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants