Html reload #54
Html reload #54
Conversation
|
Is there a way to test this PR? I just ran across this in my app and would like to have html reload work |
|
There are a couple of easy ways to test. Or, drill down into your jspm_packages and find the systemjs-hot-reloader source. Then copy paste the PR. |
|
@JordanBelford thanks, will try it out before the end of this week and release a new version |
|
I tested this, works awesome! Thanks |
| let module = System.loads[moduleImportName] | ||
| let parentModuleName | ||
| if (module && module.importers && module.importers.length) { | ||
| parentModuleName = System.loads[moduleImportName].importers[0].name |
There was a problem hiding this comment.
@JordanBelford shouldn't we iterate all importers? Won't this cause problems if one html file is imported by more than one file?
There was a problem hiding this comment.
@capaj I agree. I will try to implement multiple importers today.
|
Can you release/tag the reloader library with these changes as-is? They are working well enough to get started, and perhaps you can create another issue to track the multi-module import ? |
|
Hardcoding .html to !text is a breaking change. You should check if SystemJs has a way to resolve importers from the meta section for a file. |
|
This broke working hot-reloading for me. Transpiling and using text plugin 0.0.8 works without this code, but not with it. |
I implemented basic html reloading that is working well for my project. Load times went from 10-15 seconds to about 3 seconds.
It uses System.loads to find the module that imported the html file, and then hot reloads that parent module.
I welcome any feedback about the implementation, as I am not very familiar with this project or SystemJS's internals.
One thing to note, if there are multiple 'importers' of the html file, it should probably hot reload all of them. Currently this is only reloading the first one.
I am using browsersync, which injects css files, so combined with this project, hot reloading html, css, and js are all working.
#50