Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various #11

Merged
merged 25 commits into from Apr 25, 2012
Merged

various #11

merged 25 commits into from Apr 25, 2012

Conversation

fschwiet
Copy link
Contributor

Hi, I started using JoeBlogs to export data. I've made some modifications I thought you might like. Thanks for making your code available on github.

  • the console and integration test projects are now using .NET 4.0, because I needs it
  • I moved the console code into a new console application that makes it easier to add different commands (using ManyConsole, a library I have on nuget)
  • loading comment statuses works now, and I have an integration test verifying that.
    • I think the style of integration testing might be helpful for you otherwise, it allows faking the wordpress server to verify the code end-to-end
  • some other minor fixes (I had to deal with wordpress post IDs not fitting in a int32, and some other issue I forget)

@fschwiet
Copy link
Contributor Author

There's also a nuspec in there now for making a nuget package to put this onto nuget. I don't know if you're interested in publishing to nuget, or mind if I would. If you want, I can publish. Its a good way to make the code visible to .net developers.

@alexjamesbrown
Copy link
Owner

Looks good...
Only thing is ideally we'll take the nuget packages out of the repo-
http://coderjournal.com/2011/12/cleaning-up-your-git-repository-for-nuget-1-6/

there's loads of other "best practices" stuff about this...

any ideas?

@fschwiet
Copy link
Contributor Author

I haven't tried using package restore, though it has some benefits I'm not completely sure. I believe the benefit is reducing repo size. One risk is that nuget might take down a package (though this is controversial, I do know of at least one package that I have a dependency on thats been removed from the nuget servers). Personally I haven't found it worth the bother.

@kevininspace
Copy link

Nice work fellas.

alexjamesbrown added a commit that referenced this pull request Apr 25, 2012
@alexjamesbrown alexjamesbrown merged commit 46ecc61 into alexjamesbrown:master Apr 25, 2012
@alexjamesbrown
Copy link
Owner

great, thanks!
Would be interested in nuget if you'd like to help?

@fschwiet
Copy link
Contributor Author

My personal backlog is kind of full right now, and there is nothing WordPress related, so I'm not sure when I'll be revisiting the project. Thanks for pulling in my changes though, I help they help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants