Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .rpt2_cache to gitignore or configure to tmp directory #173

Closed
mattmazzola opened this issue Jan 31, 2018 · 3 comments
Closed

Add .rpt2_cache to gitignore or configure to tmp directory #173

mattmazzola opened this issue Jan 31, 2018 · 3 comments

Comments

@mattmazzola
Copy link
Contributor

I've used this starter library in the past and don't remember this cache folder appearing.

Perhaps there was an update to the rollup-plugin-typescript2 which starts to put cache in working directory instead of temp directory. See relate issue:
ezolenko/rollup-plugin-typescript2#34

An easy fix would be to add .rpt2_cache to the .gitignore; but better solution might be to configure the plugin to put cache somewhere that is already ignored be convention.

@alexjoverm
Copy link
Owner

Thanks for reporting this and the investigation @mattmazzola!

Let's see the options we have. I would discard moving it out to a kind of /tmp folder, since that depends on the O.S.. Then we don't have any particular ignored folder for caches. We have the compiled and build folders, but not sure if that's the best place to put it since it could interfiere and collide with the actual behaviour.

Then I'd suggest to just ignore it. Do you agree or have a better idea?

@mattmazzola
Copy link
Contributor Author

Yea, I agree that adding it to gitignore is simplest solution as well. I am not very familiar with rollup plugins so I wanted to leave it open to suggestions. I thought maybe there was some convention where all output from them should go in rollup folder.

In any case this is easy one to change again later if someone decides better, but will be good start.

@mattmazzola
Copy link
Contributor Author

See #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants