Fix husky path in semantic-release-prepare script #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Husky 1.x, the node_modules directory structure changed somewhat. The semantic-release-prepare script did not take this into account and, as a result of this, could not run to completion. Addresses #251
DrSensor
added a commit
to DrSensor/rollup-plugin-xs
that referenced
this pull request
Jan 19, 2019
Extra step: - `semantic-release-cli setup` - apply patch: alexjoverm/typescript-library-starter#266 - `npx husky-upgrade`
|
I've just try this patch and when committing change: $ git commit -S
Warning: Setting pre-commit script in package.json > scripts will be deprecated
Please move it to husky.hooks in package.json, a .huskyrc file, or a husky.config.js file
Or run ./node_modules/.bin/husky-upgrade for automatic update
See https://github.com/typicode/husky for usage
husky > pre-commit (node v10.14.1)
↓ Stashing changes... [skipped]
→ No partially staged files found...
✔ Running linters...
Warning: Setting commit-msg script in package.json > scripts will be deprecated
Please move it to husky.hooks in package.json, a .huskyrc file, or a husky.config.js file
Or run ./node_modules/.bin/husky-upgrade for automatic update
See https://github.com/typicode/husky for usage
husky > commit-msg (node v10.14.1)
/home/wildan/Projects/OSS/rollup-plugin-xs/node_modules/@commitlint/cli/lib/cli.js:113
throw err;
^
Error: Recieved 'GIT_PARAMS' as value for -E | --env, but environment variable 'GIT_PARAMS' is not available globally
at getEditValue (/home/wildan/Projects/OSS/rollup-plugin-xs/node_modules/@commitlint/cli/lib/cli.js:239:10)
at normalizeFlags (/home/wildan/Projects/OSS/rollup-plugin-xs/node_modules/@commitlint/cli/lib/cli.js:232:15)
at /home/wildan/Projects/OSS/rollup-plugin-xs/node_modules/@commitlint/cli/lib/cli.js:120:11
at new Promise (<anonymous>)
at main (/home/wildan/Projects/OSS/rollup-plugin-xs/node_modules/@commitlint/cli/lib/cli.js:117:9)
at Object.<anonymous> (/home/wildan/Projects/OSS/rollup-plugin-xs/node_modules/@commitlint/cli/lib/cli.js:109:1)
at Module._compile (internal/modules/cjs/loader.js:688:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
at Module.load (internal/modules/cjs/loader.js:598:32)
at tryModuleLoad (internal/modules/cjs/loader.js:537:12)
husky > commit-msg hook failed (add --no-verify to bypass)However, |
DrSensor
suggested changes
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Husky 1.x, the node_modules directory structure changed somewhat. The semantic-release-prepare script did not take this into account and, as a result of this, could not run to completion.
Addresses #251