Choose archive type per-backup target v2 #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we picked a single archive type for all backup targets. This results in simpler backups, but means if you add a new backup target you might have to wait 364 days for your first "yearly" backup to be created. And really, the first backup of any target should be kept forever. Fixes #20.
Now that archive type is selected per-backup target, it makes sense to calculate the start time individually too.
Travis CI includes a version of Shellcheck by default that's newer than the version installed by APT (0.4.5 vs 0.3.3 currently). Both are older than the current version, but I don't want to manually juggle dependencies.
|
Obsoleted by #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opening #22 . Need to resolve archive deletion logic.