Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the # of backups at each level configurable #31

Closed
wants to merge 22 commits into from

Conversation

assistcontrol
Copy link
Collaborator

I'm curious whether anybody else is into this idea. The defaults are so completely sensible that I'm not sure anybody else would be keen to change them.

A setting of "0" means to keep indefinitely.

With it now being done three times (adding in yearly), the
deletion loop becomes repetitive. This commit factors it
out into a function.

A setting of "0" means to keep indefinitely.

With it now being done three times (adding in yearly), the
deletion loop becomes repetitive. This commit factors it
out into a function.
@alexjurkiewicz
Copy link
Owner

Using a common function for the deletion loop seems like a good idea even if the parameters aren't exposed.

Instead of hostname-type-date- (or hostname-type-date-.), simply
drop the -target entirely (hostname-type-date).
acts Outdated Show resolved Hide resolved
acts Outdated Show resolved Hide resolved
assistcontrol and others added 3 commits June 10, 2019 18:41
Would be nice to get working again.

```
$ go get -u mvdan.cc/sh/cmd/shfmt
package mvdan.cc/sh/v3/fileutil: cannot find package "mvdan.cc/sh/v3/fileutil" in any of:
	/home/travis/.gimme/versions/go1.7.4.linux.amd64/src/mvdan.cc/sh/v3/fileutil (from $GOROOT)
	/home/travis/gopath/src/mvdan.cc/sh/v3/fileutil (from $GOPATH)
package mvdan.cc/sh/v3/syntax: cannot find package "mvdan.cc/sh/v3/syntax" in any of:
	/home/travis/.gimme/versions/go1.7.4.linux.amd64/src/mvdan.cc/sh/v3/syntax (from $GOROOT)
	/home/travis/gopath/src/mvdan.cc/sh/v3/syntax (from $GOPATH)
The command "go get -u mvdan.cc/sh/cmd/shfmt" failed and exited with 1 during .
```
@assistcontrol
Copy link
Collaborator Author

I'm gradually working on a copy model that will obviate the need for the loop. It'll do a daily backup every time, and then use tarsnap's copy function to create monthly/yearly backups as needed.

@alexjurkiewicz
Copy link
Owner

alexjurkiewicz commented Jun 11, 2019 via email

@assistcontrol
Copy link
Collaborator Author

I'm gradually working on a copy model that will obviate the need for the loop. It'll do a daily backup every time, and then use tarsnap's copy function to create monthly/yearly backups as needed.

That's a lie. The copy model only affects backup, not pruning. This PR is completely separate.

Config files can now be specified with
  acts -c /path/to/acts.conf

NOTE: With this, config files are no longer automatically picked up
from $PWD.  If you were relying on this behaviour, you'll need to
use `acts -c ./acts.conf` instead.
A setting of "0" means to keep indefinitely.

With it now being done three times (adding in yearly), the
deletion loop becomes repetitive. This commit factors it
out into a function.
Instead of hostname-type-date- (or hostname-type-date-.), simply
drop the -target entirely (hostname-type-date).
There is another PR (#32) that deals with this. Let this PR just
be about configurable limits.
And use awk, which avoids the weird spacing of `wc -l`
assistcontrol added a commit that referenced this pull request Jun 14, 2019
A value of 0 means to keep indefinitely.
@assistcontrol assistcontrol deleted the configurable_limits branch June 14, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants