Fixed issue: https://github.com/gregmalcolm/python_koans/issues#issue/2…

… (sum_it uninteresting) Made the change detailed in the ticket, namely bringing 'value' into the loop, making it more obvious that the state of 'value' is retained between iterations.
alexkalderimis · Feb 4, 2011 · ff1981a · ff1981a
1 parent b52fe8d
commit ff1981a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/python 2/koans/about_generators.py b/python 2/koans/about_generators.py
@@ -81,7 +81,7 @@ def sum_it(self, seq):
         for num in seq:
             # The local state of 'value' will be retained between iterations
             value += num
-        yield value
+            yield value
 
     def test_generator_keeps_track_of_local_variables(self):
         result = self.sum_it(range(2,5))

diff --git a/python 3/koans/about_generators.py b/python 3/koans/about_generators.py
@@ -84,7 +84,7 @@ def sum_it(self, seq):
         for num in seq:
             # The local state of 'value' will be retained between iterations
             value += num
-        yield value
+            yield value
 
     def test_generator_keeps_track_of_local_variables(self):
         result = self.sum_it(range(2,5))