Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#360: Migrate to SBT #420

Merged
merged 26 commits into from
Sep 24, 2022
Merged

#360: Migrate to SBT #420

merged 26 commits into from
Sep 24, 2022

Conversation

alexklibisz
Copy link
Owner

@alexklibisz alexklibisz commented Sep 19, 2022 •
edited
Loading

Related Issue

Changes

  • Migrate build from Gradle to SBT. Implemented a custom local SBT plugin to cover a subset of the functionality of Elasticasearch's official gradle plugin for plugins.

Testing and Validation

  • Standard CI

@alexklibisz
Tests compile and some unit tests pass
e7d056b
@alexklibisz
fix build.gradle
4226bb2
@alexklibisz
Some progress on building plugin zip
4e56d32
@alexklibisz
WIP: Figured out how to access the module graph
d9407ad
@alexklibisz
WIP: progress
32ea439
@alexklibisz
WIP: Able to find transitive deps
e044aec
@alexklibisz
WIP: able to find the right Jars'
52bd333
@alexklibisz
WIP: all but ClusterSpc passing with newly-generatd plugin
1dccb18
@alexklibisz
Convert tasks to use sbt bundlePlugin
7bd00a8
@alexklibisz
Merge branch 'master' into 360-migrate-to-sbt
73db576
@alexklibisz
Fix unused import
25915ff
@alexklibisz
Add scalacOptions
158cc8b
@alexklibisz
Remove docs step
4f64a00
@alexklibisz
Clean up plugin internals a bit
0e7a670
@alexklibisz
Fix snapshot command
fb78cad
@alexklibisz
overrode the run task to fork the elasticsearch server, but this prob…
f2deab5 
…ably won't work
@alexklibisz
Found a much simpler way to create the plugin bundle zip file
c65d9ef
@alexklibisz
Simplified the build.sbt by putting back the dependency munging
ad891b2
@alexklibisz
Implemented elasticsearchPluginDownloadDistribution task
39f328c
@alexklibisz
Able to run elasticsearch from SBT
1804528
@alexklibisz
Debugging from SBT works
187ead0
@alexklibisz
Clean up
9274fcf
@alexklibisz
updted taskfile.jvm.yaml
bc8e2a4
@alexklibisz
Update developer-guide.md
ce6cd0a
@alexklibisz
Delete gradle remnants
784bd46
@alexklibisz
Last touches
7072b68
@alexklibisz alexklibisz marked this pull request as ready for review September 24, 2022 21:19
@alexklibisz alexklibisz merged commit e28378e into master Sep 24, 2022
@alexklibisz alexklibisz deleted the 360-migrate-to-sbt branch September 24, 2022 21:34
@alexklibisz alexklibisz mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@alexklibisz