-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring lib inline with react 0.14 #8
base: master
Are you sure you want to change the base?
Conversation
… style prop - previously committed test now passes. Bump minor version number to indicate new, backwards-compatible feature.
… peer dependencies to 0.14.x. Address react warnings by modifying createElement call to not pass children to img tags. Update deprecated function calls. Fix tests to expect different rendered markup from react 0.14.x
…g React.Component class
…y extra provided props through to the root element, instead of only supporting specified ones.
Again, this branch incorporates the root element props features in my other pull request. I guess it might make sense to merge that one first, then create a 0.x branch before pulling this, so react > 0.13.2 support still continues on its own legacy branch. |
@davnicwil why did you remove |
@thangngoc89 it's because I'm currently requiring the library like this: I.e. pulling from github rather than the npm central repo since my branch isn't yet merged, built, put into npm central repo etc. So before, without the build in lib/index.js in the repo, after pulling in the library I had go to node_modules, copy in the source and build it manually. Now it just works. |
Thank you for clarification. Did you heard from the author recently ? |
@davnicwil sorry, I still haven't reviewed these. As for |
Is this fixed in 0.4.0? |
hey @davnicwil would you like to be added as a maintainer? |
@kof I haven't looked at this in a long time, and likely won't be able to give it much attention until after the new year, but sure if you want to add me I would be happy to clean this up and get it merged. |
I've sent invites to @davnicwil and @smm-telus. Thank you everyone! |
This brings the min peer dependency up to react 0.14 (the react and new react-dom modules are now both depended upon @ 0.14.x).
No functionality changes, but ensures everything's in line with 0.14 so the library will now work up to at least react 0.16, and allowed for one code/perf improvement under the hood.
Does mean library will no longer work for any consumers using react < 0.14, so have bumped the major version number to 1.x.x
Changes: