-
Notifications
You must be signed in to change notification settings - Fork 115
Every property is Interpreted as String #19
Comments
Appears to have happened in the first "cleanup" commit, 5e516dc . Looks like JSONStringNode was renamed to JSONValueNode, and in the process the quotation marks for the value rendering were left in. Although, now that I think about it, there has to be some incorrect styling logic in there as well. Would be nice if that was fixed up. |
Thanks for reporting, @bvaughn let me know if you think there's a good way of fixing this, otherwise I can tackle 5e516dc#diff-a6f0767952ee74f5ede1e5927a578be5R50 Before (from README) - syntax highlighting was also different: Current: |
My apologies if I caused a regression. I'll try to take a look within the next day or two. |
… all values to be displayed as strings
Fix is available as PR #25 |
Thanks @bvaughn! |
… all values to be displayed as strings. Also fixed secondary regression that caused null or undefined values to be displayed as empty strings
Does this fix the syntax highlighting changes as well? I definitely liked seeing numbers and booleans displayed as a different color. |
Actually, no. I didn't fix the theme color regression with that commit. Sorry! Follow up coming on its way. |
@markerikson thanks for pointing out that issue as well. :) PR #25 has been updated with that fix: |
Yay, pretty colors! Thanks for the fixes. Much appreciated. |
No problem. My bad for not noticing that regression. :) |
@duncanfinney @markerikson @bvaughn thanks a lot! Updated as |
There seems to have been a regression somewhere between 0.3.0 and 0.4.0.
In 0.4.0, every property on the object is displayed as a string.
Very cool project by the way. Exactly what I needed for a chrome extension I'm making.
The text was updated successfully, but these errors were encountered: