Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Every property is Interpreted as String #19

Closed
duncanfinney opened this issue Jan 3, 2016 · 11 comments · Fixed by #25
Closed

Every property is Interpreted as String #19

duncanfinney opened this issue Jan 3, 2016 · 11 comments · Fixed by #25

Comments

@duncanfinney
Copy link

There seems to have been a regression somewhere between 0.3.0 and 0.4.0.

In 0.4.0, every property on the object is displayed as a string.

Very cool project by the way. Exactly what I needed for a chrome extension I'm making.

@markerikson
Copy link

Appears to have happened in the first "cleanup" commit, 5e516dc . Looks like JSONStringNode was renamed to JSONValueNode, and in the process the quotation marks for the value rendering were left in. Although, now that I think about it, there has to be some incorrect styling logic in there as well.

Would be nice if that was fixed up.

@chibicode
Copy link
Contributor

Thanks for reporting, @bvaughn let me know if you think there's a good way of fixing this, otherwise I can tackle

5e516dc#diff-a6f0767952ee74f5ede1e5927a578be5R50

Before (from README) - syntax highlighting was also different:

image

Current:

image

@bvaughn
Copy link
Contributor

bvaughn commented Jan 12, 2016

My apologies if I caused a regression. I'll try to take a look within the next day or two.

bvaughn added a commit to bvaughn/react-json-tree that referenced this issue Jan 12, 2016
@bvaughn
Copy link
Contributor

bvaughn commented Jan 12, 2016

Fix is available as PR #25

@duncanfinney
Copy link
Author

Thanks @bvaughn!

bvaughn added a commit to bvaughn/react-json-tree that referenced this issue Jan 12, 2016
… all values to be displayed as strings. Also fixed secondary regression that caused null or undefined values to be displayed as empty strings
@markerikson
Copy link

Does this fix the syntax highlighting changes as well? I definitely liked seeing numbers and booleans displayed as a different color.

@bvaughn
Copy link
Contributor

bvaughn commented Jan 12, 2016

Actually, no. I didn't fix the theme color regression with that commit. Sorry! Follow up coming on its way.

@bvaughn
Copy link
Contributor

bvaughn commented Jan 12, 2016

@markerikson thanks for pointing out that issue as well. :)

PR #25 has been updated with that fix:
screen shot 2016-01-12 at 8 36 52 am

@markerikson
Copy link

Yay, pretty colors!

Thanks for the fixes. Much appreciated.

@bvaughn
Copy link
Contributor

bvaughn commented Jan 12, 2016

No problem. My bad for not noticing that regression. :)
This project could use tests. Maybe I'll take the time to write a few soon.

@chibicode
Copy link
Contributor

@duncanfinney @markerikson @bvaughn thanks a lot! Updated as 0.5.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants