This repository has been archived by the owner on May 14, 2020. It is now read-only.
Fix function object’s prototype with toStringTag. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some projects is implementing objects overriding .prototype[Symbol.toStringTag] for better read in .toString output and emulate something fancy like a type system in javascript. Unfortunately, it'll crash this project since it treat non recognized types as "Custom" and current representation is JsonValue. My patch just check for this case and use object representation instead.
|
This looks good to me, shouldn't break other cases. I just moved this part to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some projects are implementing objects overriding
.prototype[Symbol.toStringTag]for better readin .toString output and "emulate" something fancy like a typed system in javascript. (example project: https://github.com/origamitower/folktale)
Unfortunately, it'll crash this project since it treat non recognized types as "Custom" and current representation is JsonValue.
My patch just check for this case and use object representation instead.
btw, I don't know if it's the best solution for this problem.