Conversation
I'm changed this PR, just use flex layout to fixed action preview header on the top: /cc @zalmoxisus |
'align-items': 'center', | ||
'border-bottom-width': '1px', | ||
'border-bottom-style': 'solid', | ||
'min-height': '30px', | ||
'min-height': '40px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about flex: 0 0 40px
instead of min-height
and flex-basis
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that will be better. it's done, I also removed margin-bottom
of tabSelector
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zalmoxisus because I used min-height
and flex-basis
before, 30px will get unexpected result, but we should keep 30px for change to flex: '0 0 px'
, it's my fault, I'll update it.
698ee5e
to
3dee9d1
Compare
I might be missing something, but using this patch and adding <div style={{
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
width: '100%',
+ height: '100%',
+ backgroundColor: '#ccc',
minHeight: '20rem'
}}> to the demo, I'm getting the same issue in the first case as reported: |
@zalmoxisus, I missing add |
@jhen0409, it did the trick, thanks! Not sure you noticed also my comment on the outdated diff. |
@alexkuz @zalmoxisus any update on this? :) |
@jhen0409 I'll try to take a closer look on this (and other stuff I'm shamelessly ignoring lately) this or next weekend. Sorry for making you wait! |
Currently we cannot set correctly
height: 100%
to custom tab content height:Set
flex: 1
toactionPreview
style will succeed: