Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codemirror style for TestGenerator #228

Closed
wants to merge 1 commit into from

Conversation

jhen0409
Copy link
Collaborator

Before

2016-10-15 5 10 11

After

2016-10-15 5 10 42

@jhen0409
Copy link
Collaborator Author

But it doesn't completely solve the problem, if Inspector layout is Up-Down mode:

2016-10-15 6 05 20

So I make alexkuz/redux-devtools-inspector#46.

@zalmoxisus
Copy link
Owner

@jhen0409, thanks a lot for working on this! The funny part is that I was using the same workaround (and yes it worked only in the first case), but removed it in ac998cc as for some reason it was freezing the browser when the window is too small (strangely this bug appeared with Chorome 42).

Better to address it in the Inspector Monitor, making the inner part scrollable and the toolbar fixed on the top, which is a problem not only for custom components.

@zalmoxisus
Copy link
Owner

It still hangs the browser in the latest Chrome, though fixed in Canary. To reproduce, make the window small and click the Test tab.

@jhen0409
Copy link
Collaborator Author

@zalmoxisus, ok. :D Just checkout alexkuz/redux-devtools-inspector#46, it should can be solved the problem.

@jhen0409 jhen0409 closed this Oct 16, 2016
@jhen0409 jhen0409 deleted the patch-6 branch October 16, 2016 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants