This repository has been archived by the owner on Jun 5, 2020. It is now read-only.
Support for Symbols in action types #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkuz
suggested changes
Jan 8, 2017
| @@ -234,7 +234,7 @@ export default connect( | |||
| payload: Array.from({ length: 10000 }).map((_, i) => i) | |||
| }), | |||
| addFunction: () => ({ type: 'ADD_FUNCTION' }), | |||
| addSymbol: () => ({ type: 'ADD_SYMBOL' }), | |||
| addSymbol: () => ({ type: Symbol('ADD_SYMBOL') }), | |||
There was a problem hiding this comment.
Please add window. here - just to make eslint happy
| @@ -92,6 +92,6 @@ export default { | |||
| ) : state, | |||
| addFunction: (state=null, action) => action.type === 'ADD_FUNCTION' ? | |||
| { f: FUNC } : state, | |||
| addSymbol: (state=null, action) => action.type === 'ADD_SYMBOL' ? | |||
| addSymbol: (state=null, action) => action.type === Symbol('ADD_SYMBOL') ? | |||
| @@ -48,7 +48,7 @@ export default class ActionListRow extends Component { | |||
| isInFuture && 'actionListFromFuture' | |||
| ], isSelected, action)}> | |||
| <div {...styling(['actionListItemName', isSkipped && 'actionListItemNameSkipped'])}> | |||
| {action.type} | |||
| {action.type !== null && action.type.toString()} | |||
There was a problem hiding this comment.
I suggest something like this:
action.type === null ?
'<NULL>' :
(action.type.toString() || '<EMPTY>')There was a problem hiding this comment.
That looks great. Will change now. Thanks for the review!
|
Even though Redux warns when having |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just reimplements gaearon/redux-devtools-log-monitor#29 and also supports
nullas action type per gaearon/redux-devtools-log-monitor#55.There's still an error in the demo, coming from
redux-logger, as it doesn't support symbols.