Fix a bug where a href "#" would crash feed outputs.

alexlangberg · May 30, 2015 · 3fdf3f6 · 3fdf3f6
1 parent 7adedcf
commit 3fdf3f6
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/docs/goldwasher.js.html b/docs/goldwasher.js.html
@@ -131,11 +131,17 @@ <h1 class="page-title">Source: goldwasher.js</h1>
     href = domObject.next('a').attr('href');
   }
 
+  // no valid href here, return url
+  if (href === '#') {
+    return url;
+  }
+
   // check for relative URLs and append URL if relative
   if (url &amp;&amp; href &amp;&amp; !v.isURL(href)) {
     href = url + href;
   }
 
+  // if still no href, just return url
   if (!href) {
     return url;
   }
@@ -575,7 +581,7 @@ <h2><a href="index.html">Index</a></h2>
 <br clear="both">
 
 <footer>
-    Documentation generated by <a href="https://github.com/jsdoc3/jsdoc">JSDoc 3.3.0-alpha5</a> on Sat May 30 2015 18:26:38 GMT+0200 (CEST)
+    Documentation generated by <a href="https://github.com/jsdoc3/jsdoc">JSDoc 3.3.0-alpha5</a> on Sat May 30 2015 23:38:18 GMT+0200 (CEST)
 </footer>
 
 <script> prettyPrint(); </script>

diff --git a/docs/index.html b/docs/index.html
@@ -317,7 +317,7 @@ <h2><a href="index.html">Index</a></h2>
 <br clear="both">
 
 <footer>
-    Documentation generated by <a href="https://github.com/jsdoc3/jsdoc">JSDoc 3.3.0-alpha5</a> on Sat May 30 2015 18:26:38 GMT+0200 (CEST)
+    Documentation generated by <a href="https://github.com/jsdoc3/jsdoc">JSDoc 3.3.0-alpha5</a> on Sat May 30 2015 23:38:18 GMT+0200 (CEST)
 </footer>
 
 <script> prettyPrint(); </script>

diff --git a/lib/goldwasher.js b/lib/goldwasher.js
@@ -104,11 +104,17 @@ var getCheerioClosestHref = function(domObject, url) {
     href = domObject.next('a').attr('href');
   }
 
+  // no valid href here, return url
+  if (href === '#') {
+    return url;
+  }
+
   // check for relative URLs and append URL if relative
   if (url && href && !v.isURL(href)) {
     href = url + href;
   }
 
+  // if still no href, just return url
   if (!href) {
     return url;
   }

diff --git a/test/goldwasher.spec.js b/test/goldwasher.spec.js
@@ -49,6 +49,7 @@ var testContentMeta = '<html><head>' +
                       '<meta name="author" content="Baz Barfoo">' +
                       '</head><body>' +
                       testContentHref +
+                      '<div><a href="#"><h1>invalid link</h1></a></div>' +
                       '</body></html>';
 var testContentXml = '<?xml version="1.0" encoding="UTF-8"?>' +
   '<foo><bar>' +