Update lsqadj.c

long time bug that was not tested properly because in all liboptv we never used submatrix multiplication. so n == n_large in practice, but for n < n_large this is wrong. fixed it due to the thorough testing in Python
alexlib · Oct 24, 2023 · 7c91346 · 7c91346
1 parent 2c120e1
commit 7c91346
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/liboptv/src/lsqadj.c b/liboptv/src/lsqadj.c
@@ -29,9 +29,9 @@ void ata (double *a, double *ata, int m, int n, int n_large ) {
     {
       for (j = 0; j < n; j++)
     {
-      *(ata+i*n_large+j) = 0.0;
+      *(ata+i*n+j) = 0.0;
       for (k = 0; k < m; k++)
-        *(ata+i*n_large+j) +=  *(a+k*n_large+i)  * *(a+k*n_large+j);
+        *(ata+i*n+j) +=  *(a+k*n_large+i)  * *(a+k*n_large+j);
     }
     }
 }