Support for dynamic heights and paddings #20
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Proposed Changes
Hey @alexmacarthur I've resolved the problems when height is dynamicly changed, I've changed
fill
fromforwards
tobackwards
, this way the style properties will reset upon animation, so there are no more problems with height. Also added new optioncache
, if someone expect the height to change in the future it should be disabled. To be honest caching the height isn't the best approach, height can change anytime, eg. responsive design. Maybe you should reconsider if not to remove the caching instead?I've also resolved the gotha with the padding as bonus https://github.com/alexmacarthur/slide-element#gotchas but the
box-sizing: border-box
must be use for this to work.Related Issue (if applicable)
#19
Testing Steps
Didn't add tests or changed the version, leaving that up to you :)