Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow the overflow property to be given by the user #29

Closed
paulovieira opened this issue Jan 18, 2022 · 5 comments · Fixed by #36
Closed

Feature: allow the overflow property to be given by the user #29

paulovieira opened this issue Jan 18, 2022 · 5 comments · Fixed by #36

Comments

@paulovieira
Copy link
Contributor

Proposed Feature or Bug

This would be similar to the display property (which is block by default, but can be overriden by the user using the options).

In practice it would useful to be able to specify overflow: hidden to avoid having that temporary scrollbar while the element is being shown (which causes a unpleasant jump in the text at the beginning / end of the animation).

paulovieira added a commit to paulovieira/slide-element that referenced this issue Jan 18, 2022
@Eldzej
Copy link

Eldzej commented Mar 2, 2022

For anyone else who runs into the problem of temporary scrollbar, until/unless this gets merged, it can be fixed (cross-browser) by this handy CSS snippet on whatever the element you are sliding

scrollbar-width: none;

&::-webkit-scrollbar {
  display: none;
}

@darvanen
Copy link
Contributor

darvanen commented Apr 4, 2022

I second this request.

@AlecRust
Copy link

Yeah, why is overflow: auto the default anyway?

overflow-y: hidden !important is another crude fix.

@Eldzej
Copy link

Eldzej commented Jun 21, 2022

Yeah, why is overflow: auto the default anyway?

overflow-y: hidden !important is another crude fix.

Yes, that is also good, assuming you do not have any potentially overflowing elements inside the collapsed block (various JS selectboxes, Tippy, etc)

@alexmacarthur
Copy link
Owner

The overflow value is now configurable in v2.3.0. Thanks for the patience on this!

https://github.com/alexmacarthur/slide-element/releases/tag/v2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants