Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dist folder from git #61

Closed
thiamsantos opened this issue Nov 29, 2017 · 3 comments
Closed

Remove dist folder from git #61

thiamsantos opened this issue Nov 29, 2017 · 3 comments

Comments

@thiamsantos
Copy link
Contributor

Remove dist folder from to git as it is a file automatically generated and we don't need to keep track of them. In that way would be possible to keep the pull requests more clean. To accomplish this just add the dist folder to the gitignore file and add a files property to the package.json specifying the files to be included in the package when download it from npm. Right now all the repo is included.

I would be happy to send a pull request.

@alexmacarthur
Copy link
Owner

alexmacarthur commented Dec 6, 2017

I like the idea of keeping my dist files out of the repository, but I'm opting to keep them in so that the production-ready files are ready to be grabbed by anyone who might just want to clone the repo without compiling them before use.

Love the idea of adding a files property to my package.json, though. I went ahead & implemented that in 06536ba.

@thiamsantos
Copy link
Contributor Author

thiamsantos commented Dec 6, 2017

I like the idea of keeping my dist files out of the repository, but I'm opting to keep them in so that the production-ready files are ready to be grabbed by anyone who might just want to clone the repo without compiling them before use.

The people can grab the project on unpkg here and on jsdelivr here, there's no need to keep them on the repository. Just provide a link on readme and everyone will be happy.

Some extra discussion can be found here.

@alexmacarthur
Copy link
Owner

Not a bad idea. I'll reopen and consider that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants