-
Notifications
You must be signed in to change notification settings - Fork 1
/
RadiatorValve.cpp
412 lines (351 loc) · 11.3 KB
/
RadiatorValve.cpp
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
//
// Copyright (c) 2021 Alexander Mohr
// Licensed under the terms of the GNU General Public License v3.0
//
#include "RadiatorValve.hpp"
#include <Logger.hpp>
#include <RTCMemory.hpp>
open_heat::heating::RadiatorValve::RadiatorValve(
open_heat::sensors::Temperature*& tempSensor,
open_heat::Filesystem& filesystem) :
m_filesystem(filesystem), m_temperatureSensor(tempSensor)
{
}
void open_heat::heating::RadiatorValve::setup()
{
disablePins();
}
uint64_t open_heat::heating::RadiatorValve::loop()
{
// no check necessary yet
if (rtc::offsetMillis() < rtc::read().valveNextCheckMillis) {
return rtc::read().valveNextCheckMillis;
}
// heating disabled
if (rtc::read().mode == OFF || rtc::read().mode == FULL_OPEN) {
const auto nextCheck = std::numeric_limits<uint64_t>::max();
rtc::setValveNextCheckMillis(nextCheck);
rtc::read().mode == OFF ? closeValve(VALVE_FULL_ROTATE_TIME * 2)
: openValve(VALVE_FULL_ROTATE_TIME * 2);
Logger::log(Logger::DEBUG, "Heating is turned off, disabled heating");
return nextCheck;
} else if (rtc::read().mode == UNKNOWN) {
Logger::log(Logger::ERROR, "Unknown heating mode!");
return nextCheckTime();
} // else mode is heat
// store data once to work with consistent values
const auto rtcData = rtc::read();
Logger::log(Logger::DEBUG, "trying to reach temperature: %f", rtcData.setTemp);
// also updates last measured temp
const auto measuredTemp = m_temperatureSensor->temperature();
const float predictPart
= PREDICTION_STEEPNESS * (measuredTemp - rtcData.lastMeasuredTemp);
const float predictTemp = measuredTemp + predictPart;
const auto predictionError = measuredTemp - rtcData.lastPredictedTemp;
const auto temperatureChange = measuredTemp - rtcData.lastMeasuredTemp;
const auto minTemperatureChange = 0.2;
const auto openHysteresis = 0.3f;
const auto closeHysteresis = 0.2f;
const auto absTempDiff
= std::max(rtcData.setTemp, predictTemp) - std::min(rtcData.setTemp, predictTemp);
rtc::setLastPredictedTemp(predictTemp);
Logger::log(
Logger::INFO,
"Valve loop\n"
"\tpredictTemp %.2f in %lu ms\n"
"\tpredictPart: %.2f, predictionError: %.2f\n"
"\tmeasuredTemp: %.2f, lastMeasuredTemp %.2f, setTemp %.2f \n"
"\ttemperatureChange %.2f, absTempDiff: %.2f",
predictTemp,
m_checkIntervalMillis,
predictPart,
predictionError,
measuredTemp,
rtcData.lastMeasuredTemp,
rtcData.setTemp,
temperatureChange,
absTempDiff);
if (0 == predictTemp) {
const auto nextCheck = nextCheckTime();
Logger::log(Logger::DEBUG, "Skipping temperature setting, predictTemp = 0");
return nextCheck;
}
// Act according to the prediction.
if (predictTemp < (rtcData.setTemp - openHysteresis)) {
if (temperatureChange < minTemperatureChange) {
handleTempTooLow(rtcData, measuredTemp, predictTemp, openHysteresis);
} else {
Logger::log(
Logger::INFO,
"RISE, NO ADJUST: Temp old %.2f, temp now %.2f, temp change %.2f",
rtcData.lastMeasuredTemp,
measuredTemp,
temperatureChange);
}
} else if (predictTemp > (rtcData.setTemp + closeHysteresis)) {
if (temperatureChange >= -minTemperatureChange) {
handleTempTooHigh(rtcData, predictTemp, closeHysteresis);
} else {
Logger::log(
Logger::INFO,
"SINK, NO ADJUST: Temp old %.2f, temp now %.2f, temp change %.2f",
rtc::read().lastMeasuredTemp,
measuredTemp,
temperatureChange);
}
} else {
Logger::log(Logger::INFO, "Temperature is in tolerance, not changing");
}
return nextCheckTime();
}
void open_heat::heating::RadiatorValve::handleTempTooHigh(
const open_heat::rtc::Memory& rtcData,
const float predictTemp,
const float closeHysteresis)
{
auto closeTime = 200;
const auto predictDiff = rtcData.setTemp - predictTemp - closeHysteresis;
Logger::log(Logger::INFO, "Close predict diff: %f", predictDiff);
if (predictDiff <= 2) {
closeTime = 5000;
} else if (predictDiff <= 1.5) {
closeTime = 4000;
} else if (predictDiff <= 1) {
closeTime = 2500;
} else if (predictDiff <= 0.5) {
closeTime = 1500;
}
closeTime -= m_spinUpMillis;
if (closeTime <= 0) {
return;
}
closeValve(closeTime);
}
void open_heat::heating::RadiatorValve::handleTempTooLow(
const open_heat::rtc::Memory& rtcData,
const float measuredTemp,
const float predictTemp,
const float openHysteresis)
{
auto openTime = 350;
const float largeTempDiff = 3;
const auto predictDiff = rtcData.setTemp - predictTemp - openHysteresis;
Logger::log(Logger::INFO, "Open predict diff: %f", predictDiff);
if (
rtcData.setTemp - predictTemp > largeTempDiff
&& rtcData.setTemp - measuredTemp > largeTempDiff) {
openTime *= 10;
} else if (predictDiff >= 2) {
openTime = 3000;
} else if (predictDiff >= 1.5) {
openTime = 2500;
} else if (predictDiff >= 1) {
openTime = 1500;
} else if (predictDiff >= 0.5) {
openTime = 1000;
}
openTime -= m_spinUpMillis;
if (openTime <= 0) {
return;
}
openValve(openTime);
}
uint64_t open_heat::heating::RadiatorValve::nextCheckTime()
{
const auto nextCheck = rtc::offsetMillis() + m_checkIntervalMillis;
rtc::setValveNextCheckMillis(nextCheck);
return nextCheck;
}
float open_heat::heating::RadiatorValve::getConfiguredTemp()
{
return rtc::read().setTemp;
}
void open_heat::heating::RadiatorValve::setConfiguredTemp(float temp)
{
if (temp == rtc::read().setTemp) {
return;
}
open_heat::Logger::log(open_heat::Logger::INFO, "New target temperature %f", temp);
rtc::setSetTemp(temp);
setNextCheckTimeNow();
updateConfig();
for (const auto& handler : m_setTempChangeHandler) {
handler(temp);
}
}
void open_heat::heating::RadiatorValve::updateConfig()
{
const auto rtcMem = rtc::read();
auto& config = m_filesystem.getConfig();
config.SetTemperature = rtcMem.setTemp;
config.Mode = rtcMem.mode;
m_filesystem.persistConfig();
}
void open_heat::heating::RadiatorValve::closeValve(unsigned int rotateTime)
{
if (rtc::read().currentRotateTime <= (-VALVE_FULL_ROTATE_TIME)) {
open_heat::Logger::log(
open_heat::Logger::DEBUG,
"Valve already fully closed, current rotate time: %i",
rtc::read().currentRotateTime);
return;
}
if (rtc::read().currentRotateTime < 0) {
rotateTime = remainingRotateTime(static_cast<int>(rotateTime), true);
}
rtc::setCurrentRotateTime(
rtc::read().currentRotateTime - rotateTime, VALVE_FULL_ROTATE_TIME);
const auto& config = m_filesystem.getConfig().MotorPins;
open_heat::Logger::log(
open_heat::Logger::DEBUG,
"Closing valve for %ims, currentRotateTime: %ims, vin: %i, ground: %i",
rotateTime,
rtc::read().currentRotateTime,
config.Vin,
config.Ground);
rotateValve(rotateTime, config, HIGH, LOW);
}
void open_heat::heating::RadiatorValve::openValve(unsigned int rotateTime)
{
if (rtc::read().currentRotateTime >= VALVE_FULL_ROTATE_TIME) {
open_heat::Logger::log(
open_heat::Logger::DEBUG,
"Valve already fully open, current rotate time: %i",
rtc::read().currentRotateTime);
return;
}
if (rtc::read().currentRotateTime > 0) {
rotateTime = remainingRotateTime(static_cast<int>(rotateTime), false);
}
rtc::setCurrentRotateTime(
rtc::read().currentRotateTime + rotateTime, VALVE_FULL_ROTATE_TIME);
const auto& config = m_filesystem.getConfig().MotorPins;
open_heat::Logger::log(
open_heat::Logger::DEBUG,
"Opening valve for %ims, currentRotateTime: %ims, vin: %i, ground: %i",
rotateTime,
rtc::read().currentRotateTime,
config.Vin,
config.Ground);
rotateValve(rotateTime, config, LOW, HIGH);
}
unsigned int open_heat::heating::RadiatorValve::remainingRotateTime(
int rotateTime,
bool close)
{
int remainingTime;
// if close and rotate time is positive
// or open and rotate time is negative
// we still have the full range left
if ((close && rotateTime < 0) || (!close && rotateTime > 0)) {
remainingTime = VALVE_FULL_ROTATE_TIME - std::abs(rtc::read().currentRotateTime);
} else {
remainingTime = VALVE_FULL_ROTATE_TIME;
}
if (remainingTime <= 0 || rotateTime > remainingTime) {
// correct for eventual offsets
rotateTime = m_finalRotateMillis;
}
return rotateTime;
}
void open_heat::heating::RadiatorValve::rotateValve(
unsigned int rotateTime,
const PinSettings& config,
int vinState,
int groundState)
{
enablePins();
digitalWrite(static_cast<uint8_t>(config.Vin), vinState);
digitalWrite(static_cast<uint8_t>(config.Ground), groundState);
delay(rotateTime + m_spinUpMillis);
disablePins();
Logger::log(Logger::DEBUG, "Rotating valve done");
}
void open_heat::heating::RadiatorValve::disablePins()
{
const auto& config = m_filesystem.getConfig().MotorPins;
digitalWrite(static_cast<uint8_t>(config.Vin), LOW);
digitalWrite(static_cast<uint8_t>(config.Ground), LOW);
pinMode(static_cast<uint8_t>(config.Vin), INPUT);
pinMode(static_cast<uint8_t>(config.Ground), INPUT);
}
void open_heat::heating::RadiatorValve::enablePins()
{
const auto& config = m_filesystem.getConfig().MotorPins;
pinMode(static_cast<uint8_t>(config.Vin), OUTPUT);
pinMode(static_cast<uint8_t>(config.Ground), OUTPUT);
}
void open_heat::heating::RadiatorValve::setMode(const OperationMode mode)
{
if (rtc::read().isWindowOpen) {
rtc::setRestoreMode(false);
}
if (mode == rtc::read().mode) {
return;
}
rtc::setMode(mode);
updateConfig();
setNextCheckTimeNow();
for (const auto& handler : m_OpModeChangeHandler) {
handler(rtc::read().mode);
}
}
OperationMode open_heat::heating::RadiatorValve::getMode()
{
return rtc::read().mode;
}
const char* open_heat::heating::RadiatorValve::modeToCharArray(const OperationMode mode)
{
if (mode == HEAT) {
return "heat";
} else if (mode == OFF) {
return "off";
} else {
return "unknown";
}
}
void open_heat::heating::RadiatorValve::registerSetTempChangedHandler(
const std::function<void(float)>& handler)
{
m_setTempChangeHandler.push_back(handler);
}
void open_heat::heating::RadiatorValve::registerModeChangedHandler(
const std::function<void(OperationMode)>& handler)
{
m_OpModeChangeHandler.push_back(handler);
}
void open_heat::heating::RadiatorValve::setWindowState(const bool isOpen)
{
if (isOpen == rtc::read().isWindowOpen) {
Logger::log(Logger::DEBUG, "Window mode %i already set", isOpen);
return;
}
if (isOpen) {
Logger::log(Logger::DEBUG, "Storing mode, window open");
rtc::setLastMode(rtc::read().mode);
setMode(OFF);
rtc::setRestoreMode(true);
} else {
if (rtc::read().restoreMode) {
Logger::log(Logger::DEBUG, "Restoring mode, window closed");
rtc::setValveNextCheckMillis(rtc::offsetMillis() + SLEEP_MILLIS_AFTER_WINDOW_CLOSE);
setMode(rtc::read().lastMode);
} else {
Logger::log(
Logger::DEBUG, "Mode changed while window was open, not enabled old mode");
}
}
for (const auto& stateHandler : m_windowStateHandler) {
stateHandler(isOpen);
}
rtc::setIsWindowOpen(isOpen);
}
void open_heat::heating::RadiatorValve::registerWindowChangeHandler(
const std::function<void(bool)>& handler)
{
m_windowStateHandler.push_back(handler);
}
void open_heat::heating::RadiatorValve::setNextCheckTimeNow()
{
rtc::setValveNextCheckMillis(0);
}