Check for __delete__ to detect data descriptors, as in https://github…

….com/python/cpython/pull/104517/files
alexmojaki · Nov 24, 2023 · 3d1564d · 3d1564d
1 parent aac6c49
commit 3d1564d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/pure_eval/my_getattr_static.py b/pure_eval/my_getattr_static.py
@@ -79,8 +79,10 @@ def getattr_static(obj, attr):
     klass_result = _check_class(klass, attr)
 
     if instance_result is not _sentinel and klass_result is not _sentinel:
-        if (_check_class(type(klass_result), '__get__') is not _sentinel and
-                _check_class(type(klass_result), '__set__') is not _sentinel):
+        if _check_class(type(klass_result), "__get__") is not _sentinel and (
+            _check_class(type(klass_result), "__set__") is not _sentinel
+            or _check_class(type(klass_result), "__delete__") is not _sentinel
+        ):
             return _resolve_descriptor(klass_result, obj, klass)
 
     if instance_result is not _sentinel:

diff --git a/tests/test_getattr_static.py b/tests/test_getattr_static.py
@@ -187,6 +187,10 @@ class Foo(object):
         descriptor.__set__ = lambda s, i, v: None
         self.assert_cannot_getattr(foo, 'd')
 
+        del descriptor.__set__
+        descriptor.__delete__ = lambda s, i, o: None
+        self.assert_cannot_getattr(foo, 'd')
+
     def test_metaclass_with_descriptor(self):
         class descriptor(object):
             def __get__(self, instance, owner):