Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS SDK version 2 #23

Open
danfink opened this issue Jan 27, 2020 · 7 comments · May be fixed by #24
Open

Support AWS SDK version 2 #23

danfink opened this issue Jan 27, 2020 · 7 comments · May be fixed by #24

Comments

@danfink
Copy link

danfink commented Jan 27, 2020

s3upload now has a dependency on AWS SDK version 1. AWS SDK Version 2 is more flexible and is what will be supported going forward. As more applications, like ours, upgrade to Version 2, it becomes more critical to support the current version from AWS.

@alexmojaki
Copy link
Owner

Do you think I should make the library support (but not require installing) both, and if so, how do I specify that in terms of maven dependencies and build?

@danfink
Copy link
Author

danfink commented Jan 27, 2020

That's an interesting question.

I can see that both versions can be supported at the same time (https://docs.aws.amazon.com/sdk-for-java/v2/migration-guide/aws-sdk-java-mg.pdf under "Using the SDK for Java 1.x and 2.x Side by Side") so it is possible to include support for both. That said, it seems that the following would support both older and newer users:

  1. Upgrade s3upload to only use SDK 2.
  2. If someone is using SDK 1, then both libraries will be included and they won't have a problem.
  3. If someone is using SDK 2, they will just have the SDK 2 library included.
    How does this sound?

@alexmojaki alexmojaki linked a pull request Jan 28, 2020 that will close this issue
@alexmojaki
Copy link
Owner

OK, I started on this in #24 but it's incomplete. I'm not planning on finishing it off myself unless I hear a real use case where the v2 SDK is actually needed. If you could help that'd be great.

@oldirtybasti
Copy link

Thank you for this great piece of software!
I did upgrade my application to v2 SDK currently but unfortunately still need to have v1 on the classpath. Just wanted to let you know, that there are other people out there having the same problem.

@alexmojaki
Copy link
Owner

@oldirtybasti but what is the problem exactly with having v1 on the classpath? Is it just a bit more memory usage? Are there naming conflicts?

I'm glad you like the software but I work on a lot of open source software and this one is low on the list of priorities. If you really want this, consider helping with #24.

@oldirtybasti
Copy link

The technical impact indeed is minor. It is more about aesthetics: Keeping the classpath as tidy as possible and all artefacts small. I understand that this feature is of low priority.

@ericpapaluca
Copy link

OK, I started on this in #24 but it's incomplete. I'm not planning on finishing it off myself unless I hear a real use case where the v2 SDK is actually needed. If you could help that'd be great.

We're facing an issue where support for this would be fantastic as we are trying to integrate using AWS X-Ray with your library. This doesn't work with the V1 SDK as described here as a Won't Fix: aws/aws-sdk-java#1572

I will have a look at #24 above and see if I can get it working in the mean time and contribute something back.

P.S. Love your tool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants