Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 TransferManager incompatible with AWS X-Ray #1572

Closed
willvk opened this issue May 1, 2018 · 2 comments
Closed

S3 TransferManager incompatible with AWS X-Ray #1572

willvk opened this issue May 1, 2018 · 2 comments
Labels
feature-request A feature should be added or improved.

Comments

@willvk
Copy link

willvk commented May 1, 2018

Having a few problems trying to trace a component, such as TransferManager, which manages its own thread pool. My guess would be to write your own extends of ExecutorService and then use the setExecutor(). This seems invasive and I think that integration between TransferManager and Xray should be provided more easily.

This issue/feature is similar to the one raised in the python library;
python github issue 52

Currently we have pulled the use of Transfer Manager and have reverted to just serially calling it for each part of our multipart upload, due to S3 Segment Not Found which results when the threads try to execute the upload.

Ideally Transfer Manager would be enhanced to be more compatible with Xray by enabling the TransferManagerBuilder to take a .withTraceEntity(Entity segment), which could then be injected into the new threads within that threadpool.
Injecting Trace Entity

@millems millems added the feature-request A feature should be added or improved. label May 1, 2018
@debora-ito
Copy link
Member

Hi @willvk the SDK team has reviewed the feature request list for V1, and since they're concentrating efforts on V2 new features they decided to not implement this one in V1. It's still being considered for the TransferManager refactor in V2, see the referenced issue above. I'll go ahead and close this.

Please feel free to comment on the V2 issue with your use case, and reach out if you have further questions.

@Zhenye-Na
Copy link

Hey, are there any updates for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

4 participants