This repository has been archived by the owner on Mar 1, 2023. It is now read-only.
Handling versions since 3.5.3 #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiler configuration abstracted by JasperConfigurator interface. Two implementation provided for versions 3.5.3 <= v < 4.6.0 and v >=4.6.0. All jasper dependencies scoped to 'provided'. The version will be resolved based on target project's jasper dependency version. Jasper dependency lowered to 4.6.0 as it is first version where DefaultJasperReportsContext class appears. No need to have the newest version as it does not change the way compiler is initialized.
| @@ -79,7 +84,8 @@ | |||
| <dependency> | |||
| <groupId>net.sf.jasperreports</groupId> | |||
| <artifactId>jasperreports</artifactId> | |||
| <version>6.1.1</version> | |||
| <version>4.6.0</version> | |||
There was a problem hiding this comment.
If all versions are configurable, this should remain at version 6. Otherwise people using version 6 run into trouble. The reason that I didn't support multiple versions before is exactly this problem: you need the matching jasper version in the plugin as well. See #25
There was a problem hiding this comment.
Could you explain why you need matching jasper version in the plugin? I did test with different version 3.5.3 to 6.1.1 and although my jr templates did not compile for some versions there was proper compiler called.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at my changes. My projects uses JR version 3.7.6 so your plugin did not work for me. After short analysis I found out that what is different is how JR compiler is initialized. I abstracted configuration to different files. Proper configuration file is selected based on target project's jasper dependency version. I did not tested it with JR version 6 though I am pretty sure it will work. If you have any comments which you want to share please do so. If you like the idea feel free to incorporate it into original source.