This repository has been archived by the owner on Mar 1, 2023. It is now read-only.
Additional properties #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… available on my mac...) added other missing (?) dependencies
|
Also I just realized my rebasing to branch was a bad idea. Gotta stick to the console in the future, or get accustomed to the intellij idea git gui... |
| <id>ammachado</id> | ||
| <name>Adriano Machado</name> | ||
| <email>adriano.m.machado@hotmail.com</email> | ||
| </developer> |
There was a problem hiding this comment.
You can add yourself as a developer/contributor here if you like
|
Nice work! If you incorporate my feedback I will merge it into master and make/publish a new release. Is there any chance you could restore the formatting? If you look at the diff here in GitHub you can see that something went wrong and it thinks you have re-written all the files. |
|
Allright, it's released as version 1.7. Thanks for contributing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added the additional properties including unittest for the additional properties handling and a compilation test.
I also had to add missing(?) dependecies to the pom, please check on them before merging.
Regards,
Chris