This repository has been archived by the owner on Mar 1, 2023. It is now read-only.
Resuse CompileManager #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr updates the groupid, java package, build process, and readme to this plugins new home at pro-crafting.
Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.3.0 to 3.5.0. - [Release notes](https://github.com/codehaus-plexus/plexus-utils/releases) - [Commits](codehaus-plexus/plexus-utils@plexus-utils-3.3.0...plexus-utils-3.5.0) --- updated-dependencies: - dependency-name: org.codehaus.plexus:plexus-utils dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [plexus-compiler-api](https://github.com/codehaus-plexus/plexus-compiler) from 2.8.8 to 2.13.0. - [Release notes](https://github.com/codehaus-plexus/plexus-compiler/releases) - [Commits](codehaus-plexus/plexus-compiler@plexus-compiler-2.8.8...plexus-compiler-2.13.0) --- updated-dependencies: - dependency-name: org.codehaus.plexus:plexus-compiler-api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
* Extend readme Mention required jasperreports maven repositories for itext dependencies. Add section about jaspereports compatibility. Other small fixes
remove setting already provided by parent use version properties
* Enforce maven 3.5.2 for the build Add the maven wrapper to ensure that we always build using maven 3.5.2. Also make sure that each maven related dependency is set to 3.5.2.
fix small typo add badges for ci status and latest version
* Integrate with m2e. This fixes the "plugin execution not covered by a lifecycle configuration" message in eclipse. The plugin now runs incrementally, i.e. on every save in eclipse.
Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.5.0 to 3.5.1. - [Release notes](https://github.com/codehaus-plexus/plexus-utils/releases) - [Commits](codehaus-plexus/plexus-utils@plexus-utils-3.5.0...plexus-utils-3.5.1) --- updated-dependencies: - dependency-name: org.codehaus.plexus:plexus-utils dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pc-parent](https://github.com/Postremus/swagger-maven-plugin) from 11 to 12. - [Release notes](https://github.com/Postremus/swagger-maven-plugin/releases) - [Changelog](https://github.com/Postremus/swagger-maven-plugin/blob/master/CHANGES.md) - [Commits](https://github.com/Postremus/swagger-maven-plugin/commits) --- updated-dependencies: - dependency-name: com.pro-crafting:pc-parent dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Reuse the CompileManager rather than creating a new one for every report.
marschall
force-pushed
the
reuse-compile-manager
branch
from
710129b
to
58cd6b2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse the CompileManager rather than creating a new one for every
report.
To the best of my knowledge
JasperCompileManageris supposed to be thread-safe. In theory this would also allow us to create a customJasperReportsContextrather than modifying the default instance but this would break the assertions in some tests that check the default instance.