Enable the detection of container-formats #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, maybe it would be better implement this as function with additional flag? |
|
Ok, will do this the next days. Best regards Florian 2012/11/30 Alex Ott notifications@github.com
|
Not closing this stream can leak temporary files under certain circumstances, e.g. when the InputStream is a zip archive.
Close TikaInputStream on detect-mime-type for InputStream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that nowaday many file formats are actually container formats (e.g. Office, mkv, ...)
i wrapped the input-stream in a TikaInputStream.
The detection of information for container formats is only possible if you use TikaInputStream.
See http://tika.apache.org/1.2/detection.html#Content_Detection
This will consume more CPU and memory than the before.
So maybe take this pull-request with a grain of salt and find a good solution to furthermore
make it possible to use the old behaviour.