Enable the detection of container-formats #2

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
2 participants
@FlorianO

Due to the fact that nowaday many file formats are actually container formats (e.g. Office, mkv, ...)
i wrapped the input-stream in a TikaInputStream.

The detection of information for container formats is only possible if you use TikaInputStream.
See http://tika.apache.org/1.2/detection.html#Content_Detection

This will consume more CPU and memory than the before.
So maybe take this pull-request with a grain of salt and find a good solution to furthermore
make it possible to use the old behaviour.

@alexott

This comment has been minimized.

Show comment Hide comment
@alexott

alexott Nov 30, 2012

Owner

Hmmm, maybe it would be better implement this as function with additional flag?

Owner

alexott commented Nov 30, 2012

Hmmm, maybe it would be better implement this as function with additional flag?

@FlorianO

This comment has been minimized.

Show comment Hide comment
@FlorianO

FlorianO Dec 4, 2012

Ok, will do this the next days.

Best regards Florian

2012/11/30 Alex Ott notifications@github.com

Hmmm, maybe it would be better implement this as function with additional
flag?


Reply to this email directly or view it on GitHubhttps://github.com/alexott/clj-tika/pull/2#issuecomment-10896076.

FlorianO commented Dec 4, 2012

Ok, will do this the next days.

Best regards Florian

2012/11/30 Alex Ott notifications@github.com

Hmmm, maybe it would be better implement this as function with additional
flag?


Reply to this email directly or view it on GitHubhttps://github.com/alexott/clj-tika/pull/2#issuecomment-10896076.

Moritz Heidkamp and others added some commits Dec 13, 2012

Moritz Heidkamp
Close TikaInputStream on detect-mime-type for InputStream
Not closing this stream can leak temporary files under certain
circumstances, e.g. when the InputStream is a zip archive.
Merge pull request #1 from DerGuteMoritz/fix-tempfile-leak
Close TikaInputStream on detect-mime-type for InputStream

@FlorianO FlorianO closed this Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment