Skip to content

Commit

Permalink
- rearranged some info-docs
Browse files Browse the repository at this point in the history
- fixed bugs in tree-buffer.el concerning modeline-events
- changed default-value of create-layout frame-sizes
- some small fixes
  • Loading branch information
berndl committed May 18, 2009
1 parent 67861e7 commit f14c015
Show file tree
Hide file tree
Showing 10 changed files with 1,774 additions and 1,748 deletions.
13 changes: 13 additions & 0 deletions NEWS
Original file line number Original file line Diff line number Diff line change
@@ -1,3 +1,16 @@
* Changes for ECB version 2.40.1

** Fixed Bugs

*** Fixed a bug which prevents the ecb-windows from being vertically resizeable
This bug occured only when using Gnu Emacs.

*** Fixed a bug concerning horizontal mouse-scrolling of ecb-windows via
modeline-click when the ecb-window was not the selected window.
This bug occured only when using Gnu Emacs.



* Changes for ECB version 2.40 * Changes for ECB version 2.40


** ECB now requires full CEDET-suite being installed (at least version 1.0pre6) ** ECB now requires full CEDET-suite being installed (at least version 1.0pre6)
Expand Down
9 changes: 0 additions & 9 deletions TODO
Original file line number Original file line Diff line number Diff line change
@@ -1,12 +1,3 @@
- Implement ecb-upgrading with the new url-package of Emacs 22 and with
url-dl.el (at least copy this code into ecb-upgrade) - in combination with
tar-mode it should be possible to download and extract a new ecb-version
without any external tools like wget, tar and gzip!

- Implementing the class-browser of speedbar native with ECB in an
additional special ecb-window - a very important todo of high
priority!

- Distinction of include-tags by "" or <>. This can be done via - Distinction of include-tags by "" or <>. This can be done via
(semantic-tag-include-system-p TAG). Thanks to Markus grietsch. (semantic-tag-include-system-p TAG). Thanks to Markus grietsch.
But probably it would be the best if semantic itself does this special But probably it would be the best if semantic itself does this special
Expand Down
6 changes: 3 additions & 3 deletions ecb-create-layout.el
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -68,12 +68,12 @@
:group 'ecb-create-layout :group 'ecb-create-layout
:type 'file) :type 'file)


(defcustom ecb-create-layout-frame-width 110 (defcustom ecb-create-layout-frame-width 140
"*Frame width of the layout creation frame." "*Frame width of the layout creation frame."
:group 'ecb-create-layout :group 'ecb-create-layout
:type 'integer) :type 'integer)


(defcustom ecb-create-layout-frame-height 42 (defcustom ecb-create-layout-frame-height 51
"*Frame height of the layout creation frame." "*Frame height of the layout creation frame."
:group 'ecb-create-layout :group 'ecb-create-layout
:type 'integer) :type 'integer)
Expand All @@ -85,7 +85,7 @@
(defconst ecb-create-layout-buf-prefix " *ECB-LC-") (defconst ecb-create-layout-buf-prefix " *ECB-LC-")
(defconst ecb-create-layout-frame-name "Creation of a new ECB-layout") (defconst ecb-create-layout-frame-name "Creation of a new ECB-layout")
(defconst ecb-create-layout-all-buf-types (defconst ecb-create-layout-all-buf-types
'("directories" "history" "methods" "sources" "speedbar" "analyse")) '("directories" "history" "methods" "sources" "speedbar" "analyse" "symboldef"))


(defconst ecb-create-layout-help-text-left-right (defconst ecb-create-layout-help-text-left-right
" "
Expand Down
10 changes: 5 additions & 5 deletions ecb-layout.el
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -4139,7 +4139,7 @@ visibility of the ECB windows. ECB minor mode remains active!"
(let ((compwin-hidden (equal 'hidden (let ((compwin-hidden (equal 'hidden
(ecb-compile-window-state)))) (ecb-compile-window-state))))
(if (ecb-buffer-is-maximized-p) (if (ecb-buffer-is-maximized-p)
(ecb-maximize-ecb-buffer ecb-current-maximized-ecb-buffer-name) (ecb-maximize-ecb-buffer (ecb-maximized-ecb-buffer-name))
(ecb-redraw-layout-full)) (ecb-redraw-layout-full))
(if compwin-hidden (if compwin-hidden
(ecb-toggle-compile-window -1))) (ecb-toggle-compile-window -1)))
Expand Down Expand Up @@ -4219,8 +4219,8 @@ current edit-window is selected."
(ecb-window-select ecb-compile-window)))) (ecb-window-select ecb-compile-window))))
(ecb-info-message "Maximizing has been undone.")))) (ecb-info-message "Maximizing has been undone."))))


(defun ecb-maximized-tree-buffer-name () (defun ecb-maximized-ecb-buffer-name ()
"Return the currently maximized tree-buffer-name or nil if there is none." "Return the currently maximized special ecb-buffer-name or nil if there is none."
ecb-current-maximized-ecb-buffer-name) ecb-current-maximized-ecb-buffer-name)


(defun ecb-buffer-is-maximized-p (&optional ecb-buffer-name) (defun ecb-buffer-is-maximized-p (&optional ecb-buffer-name)
Expand All @@ -4231,8 +4231,8 @@ buffer of current layout is maximized otherwise nil."
(if ecb-buffer-name (if ecb-buffer-name
(and (ecb-buffer-is-ecb-buffer-of-current-layout-p ecb-buffer-name) (and (ecb-buffer-is-ecb-buffer-of-current-layout-p ecb-buffer-name)
(equal ecb-buffer-name (equal ecb-buffer-name
ecb-current-maximized-ecb-buffer-name)) (ecb-maximized-ecb-buffer-name)))
ecb-current-maximized-ecb-buffer-name)) (ecb-maximized-ecb-buffer-name)))


(defun ecb-maximize-ecb-buffer (ecb-buffer-name &optional preserve-selected-window) (defun ecb-maximize-ecb-buffer (ecb-buffer-name &optional preserve-selected-window)
"Maximize that window which displays the special ECB-buffer ECB-BUFFER-NAME. "Maximize that window which displays the special ECB-buffer ECB-BUFFER-NAME.
Expand Down
16 changes: 9 additions & 7 deletions ecb-symboldef.el
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -272,21 +272,23 @@ Only prints mode and info but does not find any symbol-definition."
keys ", ")) keys ", "))
"is a command with no keys")) "is a command with no keys"))
"is a function"))) "is a function")))
(insert (format "%s\n\n" (or (documentation symbol)
"Not documented")))
(setq args (ecb-symboldef-get-elisp-arglist symbol)) (setq args (ecb-symboldef-get-elisp-arglist symbol))
;; KB: We display the arglist AFTER the documentation because in GNU ;; KB: we could display the arglist AFTER the documentation because in
;; Emacs the documentation of subr's (test by subrp) contains the ;; GNU Emacs the documentation of subr's (test by subrp) contains the
;; arglist at the end of the documentation so we display it at the same ;; arglist at the end of the documentation so we could display it at the
;; place for all other functions. The internal help of GNU Emacs has an ;; same place for all other functions. The internal help of GNU Emacs
;; ugly hack for its function-help (see `describe-function-1' in ;; has an ugly hack for its function-help (see `describe-function-1' in
;; help.el) which searches for the arglist of subr's in the docu, ;; help.el) which searches for the arglist of subr's in the docu,
;; removes it from the end and inserts it again at beginning of the ;; removes it from the end and inserts it again at beginning of the
;; documentation. I'm to lazy to do the same here because it's a clumsy ;; documentation. I'm to lazy to do the same here because it's a clumsy
;; hack...but if you want the arglist in front of the docu-text you have ;; hack...but if you want the arglist in front of the docu-text you have
;; to do this here too (how to do it can be seen in ;; to do this here too (how to do it can be seen in
;; `describe-function-1'). ;; `describe-function-1').
;; but so we have at least for most functions the arglist before the
;; docs which is much better.
(and args (insert (format "%s\n\n" args))) (and args (insert (format "%s\n\n" args)))
(insert (format "%s\n\n" (or (documentation symbol)
"Not documented")))
(setq retval (format "Lisp %s" (setq retval (format "Lisp %s"
(if (commandp symbol) (if (commandp symbol)
"Command" "Command"
Expand Down
16 changes: 16 additions & 0 deletions ecb-util.el
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -665,6 +665,22 @@ results in
;; (string< (symbol-name (cdr item1)) (symbol-name (cdr item2))) ;; (string< (symbol-name (cdr item1)) (symbol-name (cdr item2)))
;; (string< (car item1) (car item2))))) ;; (string< (car item1) (car item2)))))


(defun ecb-values-of-symbol/value-list (list &optional elem-accessor)
"Return a list of values build from the members of LIST.
The result-list is a list which is build from LIST by using the
symbol-value if a list-member is a symbol and otherwise the
list-member itself.
If ELEM-ACCESSOR is a function then it is used to get that part of an elem
of LIST for which the rule above should be applied."
(let ((elem-acc (or elem-accessor 'identity)))
(mapcar (function (lambda (elem)
(let ((e (funcall elem-acc elem)))
(if (symbolp e)
(symbol-value e)
e))))
list)))

;; Maybe we should enhance this docstring ;-) ;; Maybe we should enhance this docstring ;-)
(defun ecb-member-of-symbol/value-list (value list &optional elem-accessor (defun ecb-member-of-symbol/value-list (value list &optional elem-accessor
return-accessor compare-fcn) return-accessor compare-fcn)
Expand Down
Loading

0 comments on commit f14c015

Please sign in to comment.