-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brother MFC-L2720DW image distortion with xsane if left offset is not 0 #49
Comments
Hi, I need an example of broken image |
Thank a lot! I think, I have enough information to investigate this issue. I will come back to you later, when I will have some update. |
Thank you! |
Note, the bug was in software image clipping. It was hard to reproduce with eSCL, because eSCL mostly relies on hardware image clipping. However with WSD, which relies on software image clipping (as a workaround for hardware that doesn't clip correctly) it was easy to reproduce
Fixed in Git, next release coming soon. This bug is hardware-independent, but it was hard to reproduce with eSCL, while easy to reproduce with WSD. In eSCL mode, image clipping in most cases handled by hardware. However in WSD mode, as a workaroung for hardware that doesn't clip properly, it is implemented purely in software, and implementation was broken. Thank you for reporting this bug. What is interesting, nobody was complaining before :-) |
Thank you for your rapid reaction! |
It was my stupid mistake. Please, retest. |
Fixed, please retest |
Works perfect (at least for a while :) ). |
Great! I see you've tested with several devices. May I know their names and scan modes (eSCL/WSD) to update my list? |
Yes, ofcourse! The second is a Samsung M337x 387x 407x Series (WSD mode), exact model is ProXpress M3870FD. That works fine, after firmware was updated though (V4.00.01.04 APR-09-2013 -> V4.00.02.20 MAY-27-2020). The third one available is OKI-MB472 (eSCL), model no. N22502B, but it doesn't work well. It is succesfully discovered, it reports its capabilities in eSCL mode, but fails to scan in both preview and final modes (no matter flatbed or ADF). Even with latest firmware (A01.79_0_4). |
Yes, please file a separate issue for OKI-MB472, I want to look to the logs. I would like also to look to the Brother's log, in case missed Grayscale support is my mistake (which is unlikely, though). |
Hi, I glad to see my driver included into the official AltLinux distro :-) You may consider upgrade to 0.9.9, which is basically includes changes that goes as a separate patch in AltLinux. Also, you don't need to put meson into "requires" - it is required only for building, and only if you actually use it (the "official" and supported build method is a plain Makefile) |
And yet another thing. You may want to consider inclusion of another program, written by me: https://github.com/OpenPrinting/ipp-usb It gives access to IPP-over-USB devices. Many modern devices support this protocol. In short, it is a modern replacement of the |
FWIW, I also have a Brother MFC-L2720DW and it does "only" scan in Color mode (with sane-airscan-0.99.9-67.1.x86_64 on Fedora 32 from the OBS repo linked in the readme). What kind of logs would you need to debug this? |
As usually, I need protocol trace. Uncomment the following lines in the
Logs will be in the |
perl-zeroconf.log there you go :) |
This printed doesn't announce ability to scan in Grayscale:
And the same for ADF:
This is hard to say what can I do at this case. |
I have the Brother iPrint&Scan app on my Android phone, which allows to select "Color", "Color (fast)" and "Grayscale", would a network dump of the communication help? Also, this is WSD mode, is there a way to test/force eSCL? |
I believe this app performs conversion to Grayscale in software, but if network dump is available, I will look to it. However, most likely Brother app will use Brother's proprietary protocol instead of the WSD. You may set protocol selection mode to
However in the default |
Yeah, I tried I'll see that I dump the traffic from the app and if it's using WSD provide you with pcaps. |
OK |
@evgeni do you have avahi running/working? In my tests it was required for eSCL, which was then preferred. FWIW, I have a 2750DW (not a 2720DW) and can scan grayscale out of the box no problem. Maybe they fixed it with the newer model. Or maybe a firmware update helps? |
Yes, @evgeni runs avahi, I can see it the supplied 2750DW was reported as supporting eSCL and WSD as well as Color and Grayscale modes. Actually, devices with similar model name and appearance may have very different stuffing under the hood. |
Gotcha. Side note: what’s the difference between _uscan._tcp and _uscans._tcp? |
_uscan == http, _uscans == https |
As previous change added RGB24->Grayscale8 resampling, now it is possible to emulate Grayscale mode, if device doesn't support it natively
Hi @evgeni, I've implemented Grayscale emulation for devices like yours. If you can build |
Ooh, cool, will definitely give it a try! |
The conversion works like a charm! |
- 0.99.27 plus latest upstream fixes and features + fix FTBFS when building against libxml2 + new models support tested and fixed - spec: do not use meson for build + refer to alexpevzner/sane-airscan#49 (comment) + remove meson from BR: - spec: add libtiff-devel to BR: according to upstream codebase changes
My Brother MFC-L2720DW is detected by airscan in WSD mode.
When scanning a full flatbed work field the image is fine, but if a cropped area is defined distortion occurs.
Distortion appears only if offset from the left side is non zero. If any other offsets are set (top, bottom or right sides) the image is always fine.
How to reproduce: xsane main menu -> standard options; geometry -> top-left x; 0.0 -> any other value; scan
If some debug log are needed I'm willing to provide them.
The text was updated successfully, but these errors were encountered: