airscan-trace.c: Check the path length

[zdohnal]

GCC 11 with -Werror generates an error for 'strcpy' usage, so checking
the size and returning NULL if lesser than 4 works it around.

[alexpevzner]

Hi @zdohnal,

I'd better put log_assert(NULL, str_len(path) >= 4) there, with the same comment regarding gcc 11. Technically it's the same, but looks better for human reader.

[zdohnal]

Squashed and ready. Although I find a simple ifs more readable than asserts, but it is just a POV.

[zdohnal]

Thx, @alexpevzner !

[alexpevzner]

I probably need to create 0.99.26 release now?

[alexpevzner]

Returning NULL definitely breaks logic, so reader should understand, that it never happens actually. asserts indicates a condition that expected to never happen.

[zdohnal]

I probably need to create 0.99.26 release now?

If you have time... I expected to have it downstream till a new release, so it doesn't matter to me too much.

[zdohnal]

Returning NULL definitely breaks logic, so reader should understand, that it never happens actually. asserts indicates a condition that expected to never happen.

Aha, I took that from the start of function, where you return NULL if dgb_trace is NULL, but that can happen, if it stays initialized and no one defines/enables tracing in config. So in the end it makes sense to divide the states.