Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix positioning of the dropdown and show selected #51

Merged

Conversation

wkerswell-gresham
Copy link
Contributor

Fix for issue #50

I have added the selected prop to the menu item which scrolls to the correct place in the list.
I have remove the ref on the menu and the programmatic scrollTo.
The selected props isn't used on the native select so I have not put on the items there.

When an item is in the preferred and the main countries list both items are highlighted as selected and the list scrolls to the correct location in the main list.

I have tested all the inputs on the demo.jsx manually and all seem to be work as I would expect.

Screenshot 2020-02-10 at 14 09 42

@wkerswell-gresham
Copy link
Contributor Author

@alexplumb Any chance of a review?

@anking
Copy link

anking commented Feb 26, 2020

Not sure if my problem is related to this issue but I'm experiencing the issue with positioning as well, for me the country window always does into the browser left top corner:
image

@wkerswell-gresham
Copy link
Contributor Author

Yeah that is what I was getting. This should solve that.

@AntwanSherif
Copy link

@wkerswell-gresham I have the same issue of positioning. Could you please merge the pull-request ASAP in order to fix this :)

@wkerswell-gresham
Copy link
Contributor Author

@AntwanSherif I am not a maintainer so I cannot merge it :/

@AntwanSherif
Copy link

AntwanSherif commented Mar 19, 2020

@wkerswell-gresham Is there anyway that I can use this fix locally?
I've tried downloading the package, update the index.js with your fix and then build locally, but I have webpack issues.

Do you suggest a better idea?

@wkerswell-gresham
Copy link
Contributor Author

You should be able to point to my branch specifically in your package.json.

{
    ....
    "material-ui-phone-number": "https://github.com/wkerswell-gresham/material-ui-phone-number.git#remote",
    ...
}

Would still be better if this was actually merged as this is not a great options for me as our security won't allow us to build from remote like this.

@alexplumb alexplumb merged commit 9cb1c86 into alexplumb:master Mar 20, 2020
ziktar pushed a commit to ziktar/material-ui-phone-number that referenced this pull request Jun 19, 2022
…osistioning

Fix positioning of the dropdown and show selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants