Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifier comments are not parsed properly #67

Closed
ekhaled opened this issue Aug 25, 2021 · 4 comments · Fixed by #68
Closed

Specifier comments are not parsed properly #67

ekhaled opened this issue Aug 25, 2021 · 4 comments · Fixed by #68
Labels
bug Something isn't working
Milestone

Comments

@ekhaled
Copy link
Contributor

ekhaled commented Aug 25, 2021

<script>
    /* The `a` variable description */
    let a = 1;
    /* The `b` variable description */
    let b = 'Test';
    /* The `c` variable description */
    let c = 'TestC';

    export { a, b, c };
</script>

Results in:

{
 //...
 "data":[
   {
      //...
      "description": "The `b` variable description",
      "name": "a",
      "kind": "let",
      //...
   },
   {
      //...
      "description": "The `c` variable description",
      "name": "b",
      "kind": "let",
      //...
   },
   {
      //...
      "description": "The `c` variable description",
      "name": "c",
      "kind": "let",
      //...
   },
 ]
}
@ekhaled ekhaled mentioned this issue Aug 25, 2021
@alexprey alexprey added the bug Something isn't working label Aug 25, 2021
@alexprey
Copy link
Owner

Hi @ekhaled!
Thanks for bug finding and fixing that!

alexprey added a commit that referenced this issue Aug 25, 2021
Fix issue #67: Incorrect comment parsing
@alexprey alexprey added this to the 4.0.0 milestone Aug 25, 2021
@ekhaled
Copy link
Contributor Author

ekhaled commented Aug 25, 2021

@alexprey please dont a make a release yet.. there are a couple of other edge cases like this I would like to fix first

@alexprey
Copy link
Owner

@ekhaled ok, no problem. It will be nice if you can also add unit tests for all thoose edge cases. Thoose can be useful in the feture when I'm done with typescript support.

@ekhaled
Copy link
Contributor Author

ekhaled commented Aug 25, 2021

@alexprey yes, will add unit tests for all the fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants