chore(build): remove some scripts in favor of emit-module-package-file
#149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
pkerschbaum
reviewed
Sep 28, 2022
| typescript({ module: 'ESNext' }), | ||
| // https://github.com/rollup/rollup/blob/69ff4181e701a0fe0026d0ba147f31bc86beffa8/build-plugins/emit-module-package-file.ts | ||
| { | ||
| generateBundle() { |
There was a problem hiding this comment.
would that call generateESMPackageJson or something instead of generateBundle?
There was a problem hiding this comment.
hm, this is just a plugin hook - it has to use a specific name to be called at the appropriate moment
There was a problem hiding this comment.
Ah ok, didn't know that!
|
@pkerschbaum feel free to raise a PR to update the name if you would like :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small trick that colocates generating this file with the actual build that depends~ on it.