Fix ambiguous 1st argument warnings in Ruby 2.3.x #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
zacviandier
pushed a commit
to teezily/geocoder
that referenced
this pull request
Feb 9, 2018
…g-warnings Fix ambiguous 1st argument warnings in Ruby 2.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a first argument to a method call without parentheses in Ruby 2.3.x that is a "/" delimited regular expression literal results in…
warning: ambiguous first argument; put parentheses or a space even after `/' operator
This can be fixed by either using parentheses around the arguments or using the alternative syntax for literal regular expressions. It seems cleanest to me to use the alternative syntax rather than adding the parentheses when similar nearby code lines all do not use the parentheses.