Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency warning in Ruby 3.3 and prepare for Ruby 3.4 #1643

Merged
merged 1 commit into from Jan 1, 2024
Merged

Fix dependency warning in Ruby 3.3 and prepare for Ruby 3.4 #1643

merged 1 commit into from Jan 1, 2024

Conversation

JunichiIto
Copy link
Contributor

Fix #1642

@alexreisner
Copy link
Owner

Thanks for this! I will merge, but first, one thing. Because these gems are only required for specific lookups, we might want to indicate that with a comment at the end of each line (like # for :google_premier lookup). That way, if the lookups are removed in the future, we know we can remove the dependency too. Does that make sense?

@JunichiIto
Copy link
Contributor Author

Thank you for your review. I added comments.

@alexreisner alexreisner merged commit 82d8531 into alexreisner:master Jan 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

base64 and csv will be bundled gem in Ruby 3.4
2 participants
@JunichiIto @alexreisner