Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disconnected SQL generation does not work #11

Closed
ap opened this issue Mar 9, 2016 · 4 comments
Closed

Disconnected SQL generation does not work #11

ap opened this issue Mar 9, 2016 · 4 comments

Comments

@ap
Copy link

ap commented Mar 9, 2016

$resultset->select_sql calls $resultset->_table_alias which calls $dbix_lite->driver_name which calls $dbix_lite->dbh without arguments which croaks if the DBIx::Lite does not have a database connection.

Thus, no database handle or connection, no SQL.

There ought to be tests that make sure disconnected SQL generation works.
@alranel
Copy link
Owner

alranel commented Mar 9, 2016

Good point.

@ap ap mentioned this issue Jul 16, 2016
Closed
@ap ap closed this as completed Jul 16, 2016
@alranel alranel reopened this Jul 18, 2016
@alranel alranel mentioned this issue Dec 29, 2018
Closed
alranel added a commit that referenced this issue Sep 18, 2024
@alranel
Fix disconnected mode. #11
cacf263
@alranel
Copy link
Owner

alranel commented Sep 18, 2024

Disconnected mode is now fixed. Better late than never, right? 😅

@alranel alranel closed this as completed Sep 18, 2024
@ap
Copy link
Author

ap commented Sep 19, 2024

Absolutely!

@ap
Copy link
Author

ap commented Sep 19, 2024

But why is it not indexed on CPAN any more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ap @alranel