Skip to content

Commit

Permalink
use the listen callback to ensure server.address() doesn't return null
Browse files Browse the repository at this point in the history 
Otherwise it's a race condition (one that fails each time on my machine).
  • Loading branch information
davidmarkclements committed Sep 4, 2013
1 parent a1f51df commit 8e4a6bc
Showing 1 changed file with 157 additions and 156 deletions.
313 changes: 157 additions & 156 deletions node-phantom.js
View file
Expand Up @@ -55,168 +55,169 @@ module.exports={
window.socket = socket;\n\
};\n\
</script></head><body></body></html>');
}).listen();

var io=socketio.listen(server,{'log level':1});

var port=server.address().port;
spawnPhantom(port,function(err,phantom){
if(err){
server.close();
callback(true);
return;
}
var pages={};
var cmds={};
var cmdid=0;
function request(socket,args,callback){
args.splice(1,0,cmdid);
// console.log('requesting:'+args);
socket.emit('cmd',JSON.stringify(args));

cmds[cmdid]={cb:callback};
cmdid++;
}

io.sockets.on('connection',function(socket){
socket.on('res',function(response){
// console.log(response);
var id=response[0];
var cmdId=response[1];
switch(response[2]){
case 'pageCreated':
var pageProxy={
open:function(url, callback){
if(callback === undefined){
request(socket, [id, 'pageOpen', url]);
}else{
request(socket, [id, 'pageOpenWithCallback', url], callback);
}).listen(function () {

var io=socketio.listen(server,{'log level':1});

var port=server.address().port;
spawnPhantom(port,function(err,phantom){
if(err){
server.close();
callback(true);
return;
}
var pages={};
var cmds={};
var cmdid=0;
function request(socket,args,callback){
args.splice(1,0,cmdid);
// console.log('requesting:'+args);
socket.emit('cmd',JSON.stringify(args));

cmds[cmdid]={cb:callback};
cmdid++;
}

io.sockets.on('connection',function(socket){
socket.on('res',function(response){
// console.log(response);
var id=response[0];
var cmdId=response[1];
switch(response[2]){
case 'pageCreated':
var pageProxy={
open:function(url, callback){
if(callback === undefined){
request(socket, [id, 'pageOpen', url]);
}else{
request(socket, [id, 'pageOpenWithCallback', url], callback);
}
},
close:function(callback){
request(socket,[id,'pageClose'],callbackOrDummy(callback));
},
render:function(filename,callback){
request(socket,[id,'pageRender',filename],callbackOrDummy(callback));
},
renderBase64:function(extension,callback){
request(socket,[id,'pageRenderBase64',extension],callbackOrDummy(callback));
},
injectJs:function(url,callback){
request(socket,[id,'pageInjectJs',url],callbackOrDummy(callback));
},
includeJs:function(url,callback){
request(socket,[id,'pageIncludeJs',url],callbackOrDummy(callback));
},
sendEvent:function(event,x,y,callback){
request(socket,[id,'pageSendEvent',event,x,y],callbackOrDummy(callback));
},
uploadFile:function(selector,filename,callback){
request(socket,[id,'pageUploadFile',selector,filename],callbackOrDummy(callback));
},
evaluate:function(evaluator,callback){
request(socket,[id,'pageEvaluate',evaluator.toString()].concat(Array.prototype.slice.call(arguments,2)),callbackOrDummy(callback));
},
evaluateAsync:function(evaluator,callback){
request(socket,[id,'pageEvaluateAsync',evaluator.toString()].concat(Array.prototype.slice.call(arguments,2)),callbackOrDummy(callback));
},
set:function(name,value,callback){
request(socket,[id,'pageSet',name,value],callbackOrDummy(callback));
},
get:function(name,callback){
request(socket,[id,'pageGet',name],callbackOrDummy(callback));
},
setFn: function(pageCallbackName, fn, callback) {
request(socket, [id, 'pageSetFn', pageCallbackName, fn.toString()], callbackOrDummy(callback));
}
},
close:function(callback){
request(socket,[id,'pageClose'],callbackOrDummy(callback));
},
render:function(filename,callback){
request(socket,[id,'pageRender',filename],callbackOrDummy(callback));
},
renderBase64:function(extension,callback){
request(socket,[id,'pageRenderBase64',extension],callbackOrDummy(callback));
},
injectJs:function(url,callback){
request(socket,[id,'pageInjectJs',url],callbackOrDummy(callback));
},
includeJs:function(url,callback){
request(socket,[id,'pageIncludeJs',url],callbackOrDummy(callback));
},
sendEvent:function(event,x,y,callback){
request(socket,[id,'pageSendEvent',event,x,y],callbackOrDummy(callback));
},
uploadFile:function(selector,filename,callback){
request(socket,[id,'pageUploadFile',selector,filename],callbackOrDummy(callback));
},
evaluate:function(evaluator,callback){
request(socket,[id,'pageEvaluate',evaluator.toString()].concat(Array.prototype.slice.call(arguments,2)),callbackOrDummy(callback));
},
evaluateAsync:function(evaluator,callback){
request(socket,[id,'pageEvaluateAsync',evaluator.toString()].concat(Array.prototype.slice.call(arguments,2)),callbackOrDummy(callback));
},
set:function(name,value,callback){
request(socket,[id,'pageSet',name,value],callbackOrDummy(callback));
},
get:function(name,callback){
request(socket,[id,'pageGet',name],callbackOrDummy(callback));
},
setFn: function(pageCallbackName, fn, callback) {
request(socket, [id, 'pageSetFn', pageCallbackName, fn.toString()], callbackOrDummy(callback));
}
};
pages[id] = pageProxy;
cmds[cmdId].cb(null,pageProxy);
delete cmds[cmdId];
break;
case 'phantomExited':
request(socket,[0,'exitAck']);
server.close();
io.set('client store expiration', 0);
cmds[cmdId].cb();
delete cmds[cmdId];
break;
case 'pageJsInjected':
case 'jsInjected':
cmds[cmdId].cb(JSON.parse(response[3])===true ? null : true);
delete cmds[cmdId];
break;
case 'pageOpened':
if(cmds[cmdId]!==undefined){ //if page is redirected, the pageopen event is called again - we do not want that currently.
if(cmds[cmdId].cb !== undefined){
cmds[cmdId].cb(null, response[3]);
};
pages[id] = pageProxy;
cmds[cmdId].cb(null,pageProxy);
delete cmds[cmdId];
break;
case 'phantomExited':
request(socket,[0,'exitAck']);
server.close();
io.set('client store expiration', 0);
cmds[cmdId].cb();
delete cmds[cmdId];
break;
case 'pageJsInjected':
case 'jsInjected':
cmds[cmdId].cb(JSON.parse(response[3])===true ? null : true);
delete cmds[cmdId];
break;
case 'pageOpened':
if(cmds[cmdId]!==undefined){ //if page is redirected, the pageopen event is called again - we do not want that currently.
if(cmds[cmdId].cb !== undefined){
cmds[cmdId].cb(null, response[3]);
}
delete cmds[cmdId];
}
break;
case 'pageRenderBase64Done':
cmds[cmdId].cb(null,response[3]);
delete cmds[cmdId];
break;
case 'pageGetDone':
case 'pageEvaluated':
cmds[cmdId].cb(null,JSON.parse(response[3]));
delete cmds[cmdId];
break;
case 'pageClosed':
delete pages[id]; // fallthru
case 'pageSetDone':
case 'pageJsIncluded':
case 'cookieAdded':
case 'pageRendered':
case 'pageEventSent':
case 'pageFileUploaded':
case 'pageEvaluatedAsync':
cmds[cmdId].cb(null);
delete cmds[cmdId];
break;
default:
console.error('got unrecognized response:'+response);
break;
}
break;
case 'pageRenderBase64Done':
cmds[cmdId].cb(null,response[3]);
delete cmds[cmdId];
break;
case 'pageGetDone':
case 'pageEvaluated':
cmds[cmdId].cb(null,JSON.parse(response[3]));
delete cmds[cmdId];
break;
case 'pageClosed':
delete pages[id]; // fallthru
case 'pageSetDone':
case 'pageJsIncluded':
case 'cookieAdded':
case 'pageRendered':
case 'pageEventSent':
case 'pageFileUploaded':
case 'pageEvaluatedAsync':
cmds[cmdId].cb(null);
delete cmds[cmdId];
break;
default:
console.error('got unrecognized response:'+response);
break;
}
});
socket.on('push', function(request) {
var id = request[0];
var cmd = request[1];
var callback = callbackOrDummy(pages[id] ? pages[id][cmd] : undefined);
callback(unwrapArray(request[2]));
});
var proxy={
createPage:function(callback){
request(socket,[0,'createPage'],callbackOrDummy(callback));
},
injectJs:function(filename,callback){
request(socket,[0,'injectJs',filename],callbackOrDummy(callback));
},
addCookie: function(cookie, callback){
request(socket,[0,'addCookie', cookie],callbackOrDummy(callback));
},
exit:function(callback){
request(socket,[0,'exit'],callbackOrDummy(callback));
},
on: function(){
phantom.on.apply(phantom, arguments);
},
_phantom: phantom
};

callback(null,proxy);
});
socket.on('push', function(request) {
var id = request[0];
var cmd = request[1];
var callback = callbackOrDummy(pages[id] ? pages[id][cmd] : undefined);
callback(unwrapArray(request[2]));

// An exit event listener that is registered AFTER the phantomjs process
// is successfully created.
phantom.on('exit', function(code, signal){

// Close server upon phantom crash.
if(code !== 0 && signal === null){
console.warn('phantom crash: code '+code);
server.close();
}
});
var proxy={
createPage:function(callback){
request(socket,[0,'createPage'],callbackOrDummy(callback));
},
injectJs:function(filename,callback){
request(socket,[0,'injectJs',filename],callbackOrDummy(callback));
},
addCookie: function(cookie, callback){
request(socket,[0,'addCookie', cookie],callbackOrDummy(callback));
},
exit:function(callback){
request(socket,[0,'exit'],callbackOrDummy(callback));
},
on: function(){
phantom.on.apply(phantom, arguments);
},
_phantom: phantom
};

callback(null,proxy);
});

// An exit event listener that is registered AFTER the phantomjs process
// is successfully created.
phantom.on('exit', function(code, signal){

// Close server upon phantom crash.
if(code !== 0 && signal === null){
console.warn('phantom crash: code '+code);
server.close();
}
});
});
}
Expand Down

0 comments on commit 8e4a6bc

Please sign in to comment.