Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make start.sh cope when gnome-terminal is missing, e.g. on Mac OSX #31

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

daj
Copy link
Contributor

@daj daj commented Nov 11, 2019

Relates to: #29

gnome-terminal doesn't exist on Mac OSX, so we need to cope without it. Calling vncviewer directly opens it in a new window, so that works fine (even though for me it currently shows an empty environment in RVis).

TESTING

Before fix:

$ ./start.sh 
Creating minio ... done
Creating rl_coach ... done
Creating robomaker ... done
waiting for containers to start up...
attempting to pull up sagemaker logs...
./start.sh: line 12: gnome-terminal: command not found
attempting to open vnc viewer...
./start.sh: line 15: gnome-terminal: command not found

After fix, with both errors happening:

$ ./start.sh
minio is up-to-date
Starting rl_coach ... done
robomaker is up-to-date
waiting for containers to start up...
Error: skip showing sagemaker logs because gnome-terminal is not installed.  This is normal if you are on a different OS to Ubuntu.
Error: vncviewer is not present on the PATH.  Make sure you install it and add it to the PATH.

After fix, with vncviewer added to the PATH (using sudo vi /etc/paths):

$ ./start.sh 
minio is up-to-date
Starting rl_coach ... done
robomaker is up-to-date
waiting for containers to start up...
Error: skip showing sagemaker logs because gnome-terminal is not installed.  This is normal if you are on a different OS to Ubuntu.
attempting to open vnc viewer...

```
$ ./start.sh
minio is up-to-date
Starting rl_coach ... done
robomaker is up-to-date
waiting for containers to start up...
Error: skip showing sagemaker logs because gnome-terminal is not installed.  This is normal if you are on a different OS to Ubuntu.
Error: vncviewer is not present on the PATH.  Make sure you install it and add it to the PATH.
```
@alexschultz alexschultz merged commit e9edb01 into aws-deepracer-community:master Nov 26, 2019
@daj daj deleted the macosx-fixes-start branch November 27, 2019 03:54
larsll added a commit that referenced this pull request Oct 3, 2020
* Fix for bug #29

* Fix for bug #31

* Fix for bug #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants