[+]: fixed performance issue #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2015 01:19
[+]: fixed code-style | Thx @ PHPStorm ;-) [+]: added missing php-docs [+]: added typ-hinting comments [+]: added .gitattributes (don't fetch everything via composer)
Yes, pls create another pull request ONLY with performance changes. Try to make as less changes as possible, so it would be easy to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+: fixed code-style | Thx @ PHPStorm ;-)
+: added missing php-docs
+: added typ-hinting comments
+: added .gitattributes (don't fetch everything via composer)
[~]: convert "tabs" (\t) into spaces
[-]: removed unused "use"-statements
PS: And sorry for the big pull-request (bad practice), if you want I can also create a single pull-request for the performance-changes!?